From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 15 Jul 2016 18:54:27 +0200 From: Peter Wu To: Ilia Mirkin Cc: Dave Airlie , "nouveau@lists.freedesktop.org" , Bjorn Helgaas , Mika Westerberg , "dri-devel@lists.freedesktop.org" , Linux PCI Subject: Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final) Message-ID: <20160715165427.GD2632@al> References: <20160715131218.2416-1-peter@lekensteyn.nl> <20160715163622.GC2632@al> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Fri, Jul 15, 2016 at 12:41:49PM -0400, Ilia Mirkin wrote: > On Fri, Jul 15, 2016 at 12:36 PM, Peter Wu wrote: > > On Fri, Jul 15, 2016 at 12:10:23PM -0400, Ilia Mirkin wrote: > >> On Fri, Jul 15, 2016 at 9:12 AM, Peter Wu wrote: > >> > Hi, > >> > > >> > Here are two patches to fix an issue reported on kernel bugzilla (infinite loop > >> > due to unchecked function) and a more important fix to fix hanging Optimus > >> > machines when runtime PM is enabled (with pm/pci patches). > >> > > >> > These are the final patches targeting v4.8. Changes compared to v2[1]: > >> > collected R-b from Hans and Mika and fixed a minor comment style issue. > >> > > >> > I recommend it to be merged before the pci/pm patches[2], otherwise there is a > >> > window where newer Nvidia Optimus laptops might fail to runtime resume and/or > >> > lock up. Once the pci/pm branch is merged I will propose another patch to > >> > improve reliability[3]. > >> > > >> > Known issue with patch 4: when a Nvidia HDMI audio function is present, the > >> > bridge will not suspend and hence the Nvidia card will still be powered. Fixing > >> > >> That's basically all optimus gpu's, right? Anything GT21x+ has a HDMI > >> audio subfunction, and prior to that, the nvidia gpu tended to be the > >> only gpu, or hard-muxed. > >> > >> If that's the case, that's pretty much a non-starter, IMO. > > > > For some reason the audio function tends to disappear/hide, so maybe it > > is not as problematic as it appears (see > > https://bugs.freedesktop.org/show_bug.cgi?id=75985). For my laptop I > > I'm aware of that bug. I believe this is an exceedingly rare scenario > or it would have been reported a lot more. > > > also had to runtime suspend/resume before lspci -H1 shows the device, > > loading with runpm=0 didn't return my HDMI audio device. > > Hm ok. Do you have the same laptop as the reporter of that bug? Nope, I have a Clevo P651RA (GTX965M). That reporter has a Dell XPS 15, but it also seems present for the Lenovo ThinkPad T420s (see comment on bug), Asus N56VZ, MSI GT60 2PE, Dell L502x (Launchpad 1377653), Asus G46vw (Ask Ubuntu user). There is another AU report for a GT 525M (laptop brand/model unknown). Maybe there are more affected users, but then they did not notice it because they did not use HDMI audio. > > > > The powered on issue will also only appear on devices produced in 2013 > > and newer that happen to have this ACPI _PR3 ACPI method (which is quite > > common for new machines supporting Windows 8 though). > > > > For these newer laptops, after the pci/pm merge and after a patch like > > http://www.spinics.net/lists/linux-pci/msg52601.html, the user can > > revert to the old DSM method by booting with pcie_port_pm=off which will > > retain the current behavior. > > > > The advantage of this patch is that it fixes memory corruption on some > > devices. The risk is that the card stays on because the audio subsystem > > needs some more work. FWIW, I was working on some patches that properly > > suspended in presence of the HDA controller, but somehow the audio > > device was not properly resumed resulting in "no AFG or MFG node found" > > and "snd_hda_intel 0000:01:00.1: no codecs initialized". > > Does this restriction (runpm being broken in presence of the audio > subfunction) only affect devices with _PR3? If so, that's a lot more > palatable - I bet Windows 8+ is in an era when the display-less thing > became more popular, and thus less likely to affect a ton of people. Yes it only affects those devices with _PR3. -- Kind regards, Peter Wu https://lekensteyn.nl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Wu Subject: Re: [Nouveau] [PATCH v3 0/4] nouveau RPM fixes for Optimus (final) Date: Fri, 15 Jul 2016 18:54:27 +0200 Message-ID: <20160715165427.GD2632@al> References: <20160715131218.2416-1-peter@lekensteyn.nl> <20160715163622.GC2632@al> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ilia Mirkin Cc: Linux PCI , "dri-devel@lists.freedesktop.org" , Bjorn Helgaas , "nouveau@lists.freedesktop.org" , Dave Airlie , Mika Westerberg List-Id: nouveau.vger.kernel.org T24gRnJpLCBKdWwgMTUsIDIwMTYgYXQgMTI6NDE6NDlQTSAtMDQwMCwgSWxpYSBNaXJraW4gd3Jv dGU6Cj4gT24gRnJpLCBKdWwgMTUsIDIwMTYgYXQgMTI6MzYgUE0sIFBldGVyIFd1IDxwZXRlckBs ZWtlbnN0ZXluLm5sPiB3cm90ZToKPiA+IE9uIEZyaSwgSnVsIDE1LCAyMDE2IGF0IDEyOjEwOjIz UE0gLTA0MDAsIElsaWEgTWlya2luIHdyb3RlOgo+ID4+IE9uIEZyaSwgSnVsIDE1LCAyMDE2IGF0 IDk6MTIgQU0sIFBldGVyIFd1IDxwZXRlckBsZWtlbnN0ZXluLm5sPiB3cm90ZToKPiA+PiA+IEhp LAo+ID4+ID4KPiA+PiA+IEhlcmUgYXJlIHR3byBwYXRjaGVzIHRvIGZpeCBhbiBpc3N1ZSByZXBv cnRlZCBvbiBrZXJuZWwgYnVnemlsbGEgKGluZmluaXRlIGxvb3AKPiA+PiA+IGR1ZSB0byB1bmNo ZWNrZWQgZnVuY3Rpb24pIGFuZCBhIG1vcmUgaW1wb3J0YW50IGZpeCB0byBmaXggaGFuZ2luZyBP cHRpbXVzCj4gPj4gPiBtYWNoaW5lcyB3aGVuIHJ1bnRpbWUgUE0gaXMgZW5hYmxlZCAod2l0aCBw bS9wY2kgcGF0Y2hlcykuCj4gPj4gPgo+ID4+ID4gVGhlc2UgYXJlIHRoZSBmaW5hbCBwYXRjaGVz IHRhcmdldGluZyB2NC44LiBDaGFuZ2VzIGNvbXBhcmVkIHRvIHYyWzFdOgo+ID4+ID4gY29sbGVj dGVkIFItYiBmcm9tIEhhbnMgYW5kIE1pa2EgYW5kIGZpeGVkIGEgbWlub3IgY29tbWVudCBzdHls ZSBpc3N1ZS4KPiA+PiA+Cj4gPj4gPiBJIHJlY29tbWVuZCBpdCB0byBiZSBtZXJnZWQgYmVmb3Jl IHRoZSBwY2kvcG0gcGF0Y2hlc1syXSwgb3RoZXJ3aXNlIHRoZXJlIGlzIGEKPiA+PiA+IHdpbmRv dyB3aGVyZSBuZXdlciBOdmlkaWEgT3B0aW11cyBsYXB0b3BzIG1pZ2h0IGZhaWwgdG8gcnVudGlt ZSByZXN1bWUgYW5kL29yCj4gPj4gPiBsb2NrIHVwLiAgT25jZSB0aGUgcGNpL3BtIGJyYW5jaCBp cyBtZXJnZWQgSSB3aWxsIHByb3Bvc2UgYW5vdGhlciBwYXRjaCB0bwo+ID4+ID4gaW1wcm92ZSBy ZWxpYWJpbGl0eVszXS4KPiA+PiA+Cj4gPj4gPiBLbm93biBpc3N1ZSB3aXRoIHBhdGNoIDQ6IHdo ZW4gYSBOdmlkaWEgSERNSSBhdWRpbyBmdW5jdGlvbiBpcyBwcmVzZW50LCB0aGUKPiA+PiA+IGJy aWRnZSB3aWxsIG5vdCBzdXNwZW5kIGFuZCBoZW5jZSB0aGUgTnZpZGlhIGNhcmQgd2lsbCBzdGls bCBiZSBwb3dlcmVkLiBGaXhpbmcKPiA+Pgo+ID4+IFRoYXQncyBiYXNpY2FsbHkgYWxsIG9wdGlt dXMgZ3B1J3MsIHJpZ2h0PyBBbnl0aGluZyBHVDIxeCsgaGFzIGEgSERNSQo+ID4+IGF1ZGlvIHN1 YmZ1bmN0aW9uLCBhbmQgcHJpb3IgdG8gdGhhdCwgdGhlIG52aWRpYSBncHUgdGVuZGVkIHRvIGJl IHRoZQo+ID4+IG9ubHkgZ3B1LCBvciBoYXJkLW11eGVkLgo+ID4+Cj4gPj4gSWYgdGhhdCdzIHRo ZSBjYXNlLCB0aGF0J3MgcHJldHR5IG11Y2ggYSBub24tc3RhcnRlciwgSU1PLgo+ID4KPiA+IEZv ciBzb21lIHJlYXNvbiB0aGUgYXVkaW8gZnVuY3Rpb24gdGVuZHMgdG8gZGlzYXBwZWFyL2hpZGUs IHNvIG1heWJlIGl0Cj4gPiBpcyBub3QgYXMgcHJvYmxlbWF0aWMgYXMgaXQgYXBwZWFycyAoc2Vl Cj4gPiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD03NTk4NSku IEZvciBteSBsYXB0b3AgSQo+IAo+IEknbSBhd2FyZSBvZiB0aGF0IGJ1Zy4gSSBiZWxpZXZlIHRo aXMgaXMgYW4gZXhjZWVkaW5nbHkgcmFyZSBzY2VuYXJpbwo+IG9yIGl0IHdvdWxkIGhhdmUgYmVl biByZXBvcnRlZCBhIGxvdCBtb3JlLgo+IAo+ID4gYWxzbyBoYWQgdG8gcnVudGltZSBzdXNwZW5k L3Jlc3VtZSBiZWZvcmUgbHNwY2kgLUgxIHNob3dzIHRoZSBkZXZpY2UsCj4gPiBsb2FkaW5nIHdp dGggcnVucG09MCBkaWRuJ3QgcmV0dXJuIG15IEhETUkgYXVkaW8gZGV2aWNlLgo+IAo+IEhtIG9r LiBEbyB5b3UgaGF2ZSB0aGUgc2FtZSBsYXB0b3AgYXMgdGhlIHJlcG9ydGVyIG9mIHRoYXQgYnVn PwoKTm9wZSwgSSBoYXZlIGEgQ2xldm8gUDY1MVJBIChHVFg5NjVNKS4gVGhhdCByZXBvcnRlciBo YXMgYSBEZWxsIFhQUyAxNSwKYnV0IGl0IGFsc28gc2VlbXMgcHJlc2VudCBmb3IgdGhlIExlbm92 byBUaGlua1BhZCBUNDIwcyAoc2VlIGNvbW1lbnQgb24KYnVnKSwgQXN1cyBONTZWWiwgTVNJIEdU NjAgMlBFLCBEZWxsIEw1MDJ4IChMYXVuY2hwYWQgMTM3NzY1MyksIEFzdXMKRzQ2dncgKEFzayBV YnVudHUgdXNlcikuIFRoZXJlIGlzIGFub3RoZXIgQVUgcmVwb3J0IGZvciBhIEdUIDUyNU0KKGxh cHRvcCBicmFuZC9tb2RlbCB1bmtub3duKS4KCk1heWJlIHRoZXJlIGFyZSBtb3JlIGFmZmVjdGVk IHVzZXJzLCBidXQgdGhlbiB0aGV5IGRpZCBub3Qgbm90aWNlIGl0CmJlY2F1c2UgdGhleSBkaWQg bm90IHVzZSBIRE1JIGF1ZGlvLgoKPiA+Cj4gPiBUaGUgcG93ZXJlZCBvbiBpc3N1ZSB3aWxsIGFs c28gb25seSBhcHBlYXIgb24gZGV2aWNlcyBwcm9kdWNlZCBpbiAyMDEzCj4gPiBhbmQgbmV3ZXIg dGhhdCBoYXBwZW4gdG8gaGF2ZSB0aGlzIEFDUEkgX1BSMyBBQ1BJIG1ldGhvZCAod2hpY2ggaXMg cXVpdGUKPiA+IGNvbW1vbiBmb3IgbmV3IG1hY2hpbmVzIHN1cHBvcnRpbmcgV2luZG93cyA4IHRo b3VnaCkuCj4gPgo+ID4gRm9yIHRoZXNlIG5ld2VyIGxhcHRvcHMsIGFmdGVyIHRoZSBwY2kvcG0g bWVyZ2UgYW5kIGFmdGVyIGEgcGF0Y2ggbGlrZQo+ID4gaHR0cDovL3d3dy5zcGluaWNzLm5ldC9s aXN0cy9saW51eC1wY2kvbXNnNTI2MDEuaHRtbCwgdGhlIHVzZXIgY2FuCj4gPiByZXZlcnQgdG8g dGhlIG9sZCBEU00gbWV0aG9kIGJ5IGJvb3Rpbmcgd2l0aCBwY2llX3BvcnRfcG09b2ZmIHdoaWNo IHdpbGwKPiA+IHJldGFpbiB0aGUgY3VycmVudCBiZWhhdmlvci4KPiA+Cj4gPiBUaGUgYWR2YW50 YWdlIG9mIHRoaXMgcGF0Y2ggaXMgdGhhdCBpdCBmaXhlcyBtZW1vcnkgY29ycnVwdGlvbiBvbiBz b21lCj4gPiBkZXZpY2VzLiBUaGUgcmlzayBpcyB0aGF0IHRoZSBjYXJkIHN0YXlzIG9uIGJlY2F1 c2UgdGhlIGF1ZGlvIHN1YnN5c3RlbQo+ID4gbmVlZHMgc29tZSBtb3JlIHdvcmsuICBGV0lXLCBJ IHdhcyB3b3JraW5nIG9uIHNvbWUgcGF0Y2hlcyB0aGF0IHByb3Blcmx5Cj4gPiBzdXNwZW5kZWQg aW4gcHJlc2VuY2Ugb2YgdGhlIEhEQSBjb250cm9sbGVyLCBidXQgc29tZWhvdyB0aGUgYXVkaW8K PiA+IGRldmljZSB3YXMgbm90IHByb3Blcmx5IHJlc3VtZWQgcmVzdWx0aW5nIGluICJubyBBRkcg b3IgTUZHIG5vZGUgZm91bmQiCj4gPiBhbmQgInNuZF9oZGFfaW50ZWwgMDAwMDowMTowMC4xOiBu byBjb2RlY3MgaW5pdGlhbGl6ZWQiLgo+IAo+IERvZXMgdGhpcyByZXN0cmljdGlvbiAocnVucG0g YmVpbmcgYnJva2VuIGluIHByZXNlbmNlIG9mIHRoZSBhdWRpbwo+IHN1YmZ1bmN0aW9uKSBvbmx5 IGFmZmVjdCBkZXZpY2VzIHdpdGggX1BSMz8gSWYgc28sIHRoYXQncyBhIGxvdCBtb3JlCj4gcGFs YXRhYmxlIC0gSSBiZXQgV2luZG93cyA4KyBpcyBpbiBhbiBlcmEgd2hlbiB0aGUgZGlzcGxheS1s ZXNzIHRoaW5nCj4gYmVjYW1lIG1vcmUgcG9wdWxhciwgYW5kIHRodXMgbGVzcyBsaWtlbHkgdG8g YWZmZWN0IGEgdG9uIG9mIHBlb3BsZS4KClllcyBpdCBvbmx5IGFmZmVjdHMgdGhvc2UgZGV2aWNl cyB3aXRoIF9QUjMuCi0tIApLaW5kIHJlZ2FyZHMsClBldGVyIFd1Cmh0dHBzOi8vbGVrZW5zdGV5 bi5ubApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK