From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbcGOSQF (ORCPT ); Fri, 15 Jul 2016 14:16:05 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46401 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbcGOSQD (ORCPT ); Fri, 15 Jul 2016 14:16:03 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Fri, 15 Jul 2016 11:16:15 -0700 From: "Paul E. McKenney" To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan Subject: Re: [PATCH] rcu: don't use modular infrastructure in non-modular code Reply-To: paulmck@linux.vnet.ibm.com References: <20160715161941.12756-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715161941.12756-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071518-0040-0000-0000-000000D19A95 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071518-0041-0000-0000-000004ABD094 Message-Id: <20160715181615.GN7094@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-15_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607150192 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 12:19:41PM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of tree.c is: > > init/Kconfig:config TREE_RCU > init/Kconfig: bool > > ...and update.c and sync.c are "obj-y" meaning that none are ever > built as a module by anyone. > > Since MODULE_ALIAS is a no-op for non-modular code, we can remove > them from these files. > > We leave moduleparam.h behind since the files instantiate some boot > time configuration parameters with module_param() still. > > Cc: "Paul E. McKenney" > Cc: Josh Triplett > Cc: Steven Rostedt > Cc: Mathieu Desnoyers > Cc: Lai Jiangshan > Signed-off-by: Paul Gortmaker Queued for testing and review, thank you! Initial tests show that the "#define MODULE_PARAM_PREFIX" does the job without the MODULE_ALIAS(), so that part is good. ;-) Thanx, Paul > --- > kernel/rcu/sync.c | 2 -- > kernel/rcu/tree.c | 2 -- > kernel/rcu/update.c | 3 +-- > 3 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/kernel/rcu/sync.c b/kernel/rcu/sync.c > index a33dfc9b3b0c..2c2a0721e6fa 100644 > --- a/kernel/rcu/sync.c > +++ b/kernel/rcu/sync.c > @@ -23,9 +23,7 @@ > #include > #include > #include > -#include > > -MODULE_ALIAS("rcusync"); > #ifdef MODULE_PARAM_PREFIX > #undef MODULE_PARAM_PREFIX > #endif > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index bcae3cea40fd..4bc03955a393 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -41,7 +41,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -60,7 +59,6 @@ > #include "tree.h" > #include "rcu.h" > > -MODULE_ALIAS("rcutree"); > #ifdef MODULE_PARAM_PREFIX > #undef MODULE_PARAM_PREFIX > #endif > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c > index f0d8322bc3ec..f19271dce0a9 100644 > --- a/kernel/rcu/update.c > +++ b/kernel/rcu/update.c > @@ -46,7 +46,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > @@ -54,7 +54,6 @@ > > #include "rcu.h" > > -MODULE_ALIAS("rcupdate"); > #ifdef MODULE_PARAM_PREFIX > #undef MODULE_PARAM_PREFIX > #endif > -- > 2.8.4 >