From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOwnn-0003wE-T0 for qemu-devel@nongnu.org; Sun, 17 Jul 2016 20:52:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOwnj-0000q9-O7 for qemu-devel@nongnu.org; Sun, 17 Jul 2016 20:52:54 -0400 Received: from ozlabs.org ([103.22.144.67]:56302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOwni-0000nj-OV for qemu-devel@nongnu.org; Sun, 17 Jul 2016 20:52:51 -0400 Date: Mon, 18 Jul 2016 10:44:11 +1000 From: David Gibson Message-ID: <20160718004411.GA16769@voom.fritz.box> References: <1468597179-8337-1-git-send-email-thuth@redhat.com> <1468597179-8337-2-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: <1468597179-8337-2-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/2] tests: Resort check-qtest entries in Makefile.include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Paolo Bonzini , Eric Blake , Markus Armbruster , Peter Maydell , Richard Henderson , Peter Crosthwaite , Eduardo Habkost --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 15, 2016 at 05:39:38PM +0200, Thomas Huth wrote: > The rather random list of check-qtest-xxx entries caused some > confusion in the past, where to use "=3D" and where to use "+=3D" > (see commits 0ccac16f59462b8e2b9afbc1 and 1f5c1cfbaec0792cd2e5da > for example). > Sorting the check-qtest-xxx entries by architecure instead and > using some empty lines inbetween should help to ease this > situation a little bit, so that it is hopefully now obvious > that new tests should be added with "+=3D" instead of "=3D". > While we are at it, this patch also comments out two of the > "gcov-files-..." lines since the corresponding m48t59-test is > disabled for sparc and sparc64, too. >=20 > Signed-off-by: Thomas Huth Reviewed-by: David Gibson > --- > tests/Makefile.include | 38 +++++++++++++++++++++++++------------- > 1 file changed, 25 insertions(+), 13 deletions(-) >=20 > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 2010b11..3d76cf4 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -240,33 +240,45 @@ check-qtest-i386-y +=3D tests/postcopy-test$(EXESUF) > check-qtest-x86_64-y +=3D $(check-qtest-i386-y) > gcov-files-i386-y +=3D i386-softmmu/hw/timer/mc146818rtc.c > gcov-files-x86_64-y =3D $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-fil= es-i386-y)) > + > check-qtest-mips-y =3D tests/endianness-test$(EXESUF) > + > check-qtest-mips64-y =3D tests/endianness-test$(EXESUF) > + > check-qtest-mips64el-y =3D tests/endianness-test$(EXESUF) > + > check-qtest-ppc-y =3D tests/endianness-test$(EXESUF) > -check-qtest-ppc64-y =3D tests/endianness-test$(EXESUF) > +check-qtest-ppc-y +=3D tests/boot-order-test$(EXESUF) > +check-qtest-ppc-y +=3D tests/prom-env-test$(EXESUF) > + > +check-qtest-ppc64-y =3D tests/spapr-phb-test$(EXESUF) > +gcov-files-ppc64-y =3D ppc64-softmmu/hw/ppc/spapr_pci.c > +check-qtest-ppc64-y +=3D tests/endianness-test$(EXESUF) > +check-qtest-ppc64-y +=3D tests/boot-order-test$(EXESUF) > +check-qtest-ppc64-y +=3D tests/prom-env-test$(EXESUF) > + > check-qtest-sh4-y =3D tests/endianness-test$(EXESUF) > + > check-qtest-sh4eb-y =3D tests/endianness-test$(EXESUF) > + > +check-qtest-sparc-y =3D tests/prom-env-test$(EXESUF) > +#check-qtest-sparc-y +=3D tests/m48t59-test$(EXESUF) > +#gcov-files-sparc-y =3D hw/timer/m48t59.c > + > check-qtest-sparc64-y =3D tests/endianness-test$(EXESUF) > -#check-qtest-sparc-y =3D tests/m48t59-test$(EXESUF) > #check-qtest-sparc64-y +=3D tests/m48t59-test$(EXESUF) > -gcov-files-sparc-y +=3D hw/timer/m48t59.c > -gcov-files-sparc64-y +=3D hw/timer/m48t59.c > +#gcov-files-sparc64-y +=3D hw/timer/m48t59.c > +#Disabled for now, triggers a TCG bug on 32-bit hosts > +#check-qtest-sparc64-y +=3D tests/prom-env-test$(EXESUF) > + > check-qtest-arm-y =3D tests/tmp105-test$(EXESUF) > check-qtest-arm-y +=3D tests/ds1338-test$(EXESUF) > gcov-files-arm-y +=3D hw/misc/tmp105.c > check-qtest-arm-y +=3D tests/virtio-blk-test$(EXESUF) > gcov-files-arm-y +=3D arm-softmmu/hw/block/virtio-blk.c > -check-qtest-ppc-y +=3D tests/boot-order-test$(EXESUF) > -check-qtest-ppc64-y +=3D tests/boot-order-test$(EXESUF) > -check-qtest-ppc64-y +=3D tests/spapr-phb-test$(EXESUF) > -gcov-files-ppc64-y +=3D ppc64-softmmu/hw/ppc/spapr_pci.c > -check-qtest-ppc-y +=3D tests/prom-env-test$(EXESUF) > -check-qtest-ppc64-y +=3D tests/prom-env-test$(EXESUF) > -check-qtest-sparc-y +=3D tests/prom-env-test$(EXESUF) > -#Disabled for now, triggers a TCG bug on 32-bit hosts > -#check-qtest-sparc64-y +=3D tests/prom-env-test$(EXESUF) > + > check-qtest-microblazeel-y =3D $(check-qtest-microblaze-y) > + > check-qtest-xtensaeb-y =3D $(check-qtest-xtensa-y) > =20 > check-qtest-generic-y +=3D tests/qom-test$(EXESUF) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --lrZ03NoBR/3+SXJZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXjCZbAAoJEGw4ysog2bOSFfIP/27x6Akg/FNxUcrcK0AIE0MW mMWrLt8B24faybAQjh+a1wN89qSxVH/EtyJEbFY+8cdr3wolBit+G8m2aIg8NfTX XJTvAwz6uxNdTJLiCVkRDj85MAdP41hLdUq95mG2vj1Pwv0KSZRxaLegNSa6Y/dm eM1eX4Bbff+Kgdy78IvnEXioefS40laUYzL7JorzS8MWA2u2NXn1FUWMYrNQSiNQ dNVg9T5iR8BqMUNgN9iMVOdMH/wpfFGgJ8n7fLO4B/ylohWgNfjnkZsbXiad/1CF DvxMQY0q1aZGCs6HlqU+vJpKLMwdeUI4e1i8fcOx+0eL4+hu28swQXHTbkhyOYP1 XYE+9Pm1oU/KGrjoYTBuVI5QV7n1lPKGgsfzEp0mkamXSPWwWAttVJgEhmuuDzsJ Ikn19aYs789SizAdpSr+ozWUWqT/S7wrvkLV5Qi/yGDNDJlLou5j5prbd/nRRHXU WKoGQUke+tFRrMGCOZtM0HLqQlQOY8cJ2mE1pgw3/Z5M5i1uUF5t9ZlqEo1hJ2nY 04rbrJ5WWwhSc2JDkA/WPhQteY3kyREA+1XwiDis4E51NJAXcO416phZSf1IzmPk f9LAOznY+o2aS8V8pLr0gtc/cBQLsxrnIWXDGxbSUysESG4wDCY5ck15XascbUO7 IdTanVdRhHAZtIod45Kg =cDql -----END PGP SIGNATURE----- --lrZ03NoBR/3+SXJZ--