From: Kent Overstreet <kent.overstreet@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Jens Axboe <axboe@fb.com>, Eric Wheeler <git@linux.ewheeler.net>,
Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: untagle cache_aolloc
Date: Mon, 18 Jul 2016 02:28:54 -0800 [thread overview]
Message-ID: <20160718102854.GA19374@kmo-pixel> (raw)
In-Reply-To: <20160718102411.t5qm3t6hnjcjpbyr@c203.arch.suse.de>
On Mon, Jul 18, 2016 at 12:24:11PM +0200, Johannes Thumshirn wrote:
> On Mon, Jul 18, 2016 at 02:13:33AM -0800, Kent Overstreet wrote:
> > On Mon, Jul 18, 2016 at 12:11:09PM +0200, Johannes Thumshirn wrote:
> > > bcache's cache_alloc() function currenty has no way freeing memory if one of
> > > the allocations fails. Untangle the if + allocation statement so we have
> > > defined checkpoints to free previous allocations if one fails.
> >
> > nack. The existing error path handles failure midway through just fine.
>
> Come on, the patch improves the readability of the if statement by some orders
> of magnitude as well.
>
> Are you OK with it if I change the subject/commit log?
No, it's just churn and I don't agree that it improves readability. On the
contrary, now the cleanup code has to be duplicated in two places - which
invites them getting out of sync and introducing bugs.
prev parent reply other threads:[~2016-07-18 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 10:11 [PATCH] bcache: untagle cache_aolloc Johannes Thumshirn
2016-07-18 10:13 ` Kent Overstreet
2016-07-18 10:24 ` Johannes Thumshirn
2016-07-18 10:28 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718102854.GA19374@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=axboe@fb.com \
--cc=colyli@suse.de \
--cc=git@linux.ewheeler.net \
--cc=jthumshirn@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.