From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Date: Mon, 18 Jul 2016 12:49:29 -0600 Message-ID: <20160718184929.GA19217@obsidianresearch.com> References: <1468542580-5296-1-git-send-email-apronin@chromium.org> <20160718184532.GH31463@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160718184532.GH31463-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote: > > tpm_tis_core was missing conversion from msec when assigning > > max timeouts from constants. > > > > Signed-off-by: Andrey Pronin > > Reviewed-by: Jarkko Sakkinen > Fixes: 41a5e1cf1fe1 Not sure that fixes isn't right, it looks like it has been broken for a really long time.. Jason ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752432AbcGRStq (ORCPT ); Mon, 18 Jul 2016 14:49:46 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:59134 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcGRStm (ORCPT ); Mon, 18 Jul 2016 14:49:42 -0400 Date: Mon, 18 Jul 2016 12:49:29 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Andrey Pronin , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH] tpm_tis_core: convert max timeouts from msec to jiffies Message-ID: <20160718184929.GA19217@obsidianresearch.com> References: <1468542580-5296-1-git-send-email-apronin@chromium.org> <20160718184532.GH31463@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160718184532.GH31463@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 18, 2016 at 09:45:32PM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 14, 2016 at 05:29:40PM -0700, Andrey Pronin wrote: > > tpm_tis_core was missing conversion from msec when assigning > > max timeouts from constants. > > > > Signed-off-by: Andrey Pronin > > Reviewed-by: Jarkko Sakkinen > Fixes: 41a5e1cf1fe1 Not sure that fixes isn't right, it looks like it has been broken for a really long time.. Jason