All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@lst.de>, Eryu Guan <eguan@redhat.com>,
	fstests@vger.kernel.org
Subject: Re: [PATCH] generic/071: require falloc -k
Date: Tue, 19 Jul 2016 10:30:47 +0200	[thread overview]
Message-ID: <20160719083047.GA21083@lst.de> (raw)
In-Reply-To: <7bd28494-84e9-1458-5e28-893d02dd5c06@sandeen.net>

On Mon, Jul 18, 2016 at 11:49:57PM -0700, Eric Sandeen wrote:
> Some tests actually do run xfs_io on a real file, but we probably
> don't want to go that way.
> 
> The test for finding it in help output seems way too specific,
> 
> _require_xfs_io_command "pwrite" "-Z"
> 
> fails as well because it doesn't hit the specific format in
> the grep.
> 
> What if we loosen up the test; is this too loose? (look for param
> preceded by whitespace or square bracket)

Seems like it's not loose enough as it still tries to run the test
on NFS.

  reply	other threads:[~2016-07-19  8:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18  8:06 [PATCH] generic/071: require falloc -k Christoph Hellwig
2016-07-18  8:47 ` Eryu Guan
2016-07-19  4:17   ` Christoph Hellwig
2016-07-19  6:49     ` Eric Sandeen
2016-07-19  8:30       ` Christoph Hellwig [this message]
2016-07-20  4:52         ` Eryu Guan
2016-07-20  5:34           ` Eric Sandeen
2016-07-20 12:40             ` Eryu Guan
2016-07-20  4:38       ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160719083047.GA21083@lst.de \
    --to=hch@lst.de \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.