From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shaohua Li Subject: Re: [PATCH] md: use seconds granularity for error logging Date: Tue, 19 Jul 2016 10:59:51 -0700 Message-ID: <20160719175951.GA46288@kernel.org> References: <20160617153347.380722-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160617153347.380722-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Arnd Bergmann Cc: linux-raid@vger.kernel.org, Hannes Reinecke , y2038@lists.linaro.org, NeilBrown , linux-kernel@vger.kernel.org, Jens Axboe , Guoqing Jiang , Goldwyn Rodrigues List-Id: linux-raid.ids T24gRnJpLCBKdW4gMTcsIDIwMTYgYXQgMDU6MzM6MTBQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBUaGUgbWQgY29kZSBzdG9yZXMgdGhlIGV4YWN0IHRpbWUgb2YgdGhlIGxhc3QgZXJy b3IgaW4gdGhlCj4gbGFzdF9yZWFkX2Vycm9yIHZhcmlhYmxlIHVzaW5nIGEgdGltZXNwZWMgc3Ry dWN0dXJlLiBJdCBvbmx5Cj4gZXZlciB1c2VzIHRoZSBzZWNvbmRzIHBvcnRpb24gb2YgdGhhdCB0 aG91Z2gsIHNvIHdlIGNhbgo+IHVzZSBhIHNjYWxhciBmb3IgaXQuCj4gCj4gVGhlcmUgd29uJ3Qg YmUgYW4gb3ZlcmZsb3cgaW4gMjAzOCBoZXJlLCBiZWNhdXNlIGl0IGFscmVhZHkKPiB1c2VkIG1v bm90b25pYyB0aW1lIGFuZCAzMi1iaXQgaXMgZW5vdWdoIGZvciB0aGF0LCBidXQgSSd2ZQo+IGRl Y2lkZWQgdG8gdXNlIHRpbWU2NF90IGZvciBjb25zaXN0ZW5jeSBpbiB0aGUgY29udmVyc2lvbi4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgoKQXBwbGll ZCwgdGhhbmtzIQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpZMjAzOCBtYWlsaW5nIGxpc3QKWTIwMzhAbGlzdHMubGluYXJvLm9yZwpodHRwczovL2xpc3Rz LmxpbmFyby5vcmcvbWFpbG1hbi9saXN0aW5mby95MjAzOAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753593AbcGSSAC (ORCPT ); Tue, 19 Jul 2016 14:00:02 -0400 Received: from mail.kernel.org ([198.145.29.136]:60652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753401AbcGSSAA (ORCPT ); Tue, 19 Jul 2016 14:00:00 -0400 Date: Tue, 19 Jul 2016 10:59:51 -0700 From: Shaohua Li To: Arnd Bergmann Cc: y2038@lists.linaro.org, NeilBrown , Guoqing Jiang , Goldwyn Rodrigues , Jens Axboe , Hannes Reinecke , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] md: use seconds granularity for error logging Message-ID: <20160719175951.GA46288@kernel.org> References: <20160617153347.380722-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617153347.380722-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2016 at 05:33:10PM +0200, Arnd Bergmann wrote: > The md code stores the exact time of the last error in the > last_read_error variable using a timespec structure. It only > ever uses the seconds portion of that though, so we can > use a scalar for it. > > There won't be an overflow in 2038 here, because it already > used monotonic time and 32-bit is enough for that, but I've > decided to use time64_t for consistency in the conversion. > > Signed-off-by: Arnd Bergmann Applied, thanks!