From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nf-next 3/3] netfilter: nft_log: fix snaplen does not truncate packets
Date: Tue, 19 Jul 2016 20:16:00 +0200 [thread overview]
Message-ID: <20160719181600.GD6116@salvia> (raw)
In-Reply-To: <1468845857-30291-4-git-send-email-zlpnobody@163.com>
On Mon, Jul 18, 2016 at 08:44:17PM +0800, Liping Zhang wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> There's a similar problem in xt_NFLOG, and was fixed by commit 7643507fe8b5
> ("netfilter: xt_NFLOG: nflog-range does not truncate packets"). Only set
> copy_len here does not work, so we should enable NF_LOG_F_COPY_LEN also.
Applied, thanks.
Will you send me a patch for nftables userspace to enable this flag?
It would be good to update the translation to make sure --nflog-size
map to snaplen and ignore --nflog-range.
next prev parent reply other threads:[~2016-07-19 18:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 12:44 [PATCH nf-next 0/3] netfilter: fix some small bugs related to nft_log Liping Zhang
2016-07-18 12:44 ` [PATCH nf-next 1/3] netfilter: nft_log: fix possible memory leak if log expr init fail Liping Zhang
2016-07-19 18:13 ` Pablo Neira Ayuso
2016-07-18 12:44 ` [PATCH nf-next 2/3] netfilter: nft_log: check the validity of log level Liping Zhang
2016-07-19 18:14 ` Pablo Neira Ayuso
2016-07-18 12:44 ` [PATCH nf-next 3/3] netfilter: nft_log: fix snaplen does not truncate packets Liping Zhang
2016-07-19 18:16 ` Pablo Neira Ayuso [this message]
2016-07-19 23:00 ` Liping Zhang
2016-07-20 8:25 ` Pablo Neira Ayuso
2016-07-20 9:00 ` Liping Zhang
2016-07-20 9:07 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160719181600.GD6116@salvia \
--to=pablo@netfilter.org \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.