From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v1] IB/ipoib: Report SG feature regardless of HW UD CSUM capability Date: Tue, 19 Jul 2016 14:11:13 -0600 Message-ID: <20160719201113.GC28288@obsidianresearch.com> References: <1468827648-17275-1-git-send-email-yuval.shaia@oracle.com> <20160718171921.GA3193@obsidianresearch.com> <20160719125556.GA14768@yuval-lap.uk.oracle.com> <20160719193453.GA28288@obsidianresearch.com> <20160719200231.GC6129@yuval-lap.uk.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160719200231.GC6129-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yuval Shaia Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Jul 19, 2016 at 11:02:32PM +0300, Yuval Shaia wrote: > ok, i see the point but as Leon Romanovsky mentioned - this is not an issue > with the patch itself, right? i.e. the original code relays on the fact > that HW supports UD-CSUM and did not checked QP's sg limit (we even do not > have any QP at this stage yet). ud-csum was only supported by one IB vendor and that vendor supports SG. You are changing things to enable SG on hardware that has never had SG enabled, so you need to make sure it works right.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html