From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andy Green <andy.green@linaro.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Andy Green <andy@warmcat.com>, Dave Long <dave.long@linaro.org>,
Guodong Xu <guodong.xu@linaro.org>
Subject: Re: [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio
Date: Wed, 20 Jul 2016 01:21:18 +0100 [thread overview]
Message-ID: <20160720002118.GA6509@sirena.org.uk> (raw)
In-Reply-To: <CALAqxLVG2aRAvenzgyyDpd86Y9j27L8EVYkHthxrQ0uzKrxkEQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On Tue, Jul 19, 2016 at 02:59:31PM -0700, John Stultz wrote:
> Then the probe/remove logic to register the codec, and connected it up
> with the simple card driver.
> Though it seems kind of silly to have a whole driver (and devicetree
> entry for the probe hook) just to fill and install the above
> structure. Is there a simpler way to specify that via a DT node
> instead?
Well, if you can use simple-card why not just use simple-card?
> >> +static const struct of_device_id hi6210_i2s_dt_ids[] = {
> >> + { .compatible = "hisilicon,hi6210-i2s" },
> >> + { /* sentinel */ }
> >> +};
> > The code makes this look like it's not just an I2S controller.
> I'm not sure I follow this? The dt ids make it seem like this driver
> is not an i2s controller?
No. The *code* makes this look like it's not an I2S controller. It
looks like it's a driver for a DSP/mixing block which may have an
integrated I2S controller, I pointed out things like some of the routing
control.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-20 0:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 2:13 [RFC][PATCH 0/7] Add HDMI audio support for HiKey John Stultz
2016-07-16 2:13 ` [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping John Stultz
2016-07-18 6:37 ` zhangfei
2016-07-16 2:13 ` [RFC][PATCH 2/7] k3dma: Fix dma err offsets John Stultz
2016-07-18 6:39 ` zhangfei
2016-07-16 2:13 ` [RFC][PATCH 3/7] k3dma: Fix "nobody cared" message seen on any error John Stultz
2016-07-18 6:40 ` zhangfei
2016-07-16 2:13 ` [RFC][PATCH 4/7] k3dma: Add cyclic mode for audio John Stultz
2016-07-18 6:43 ` zhangfei
2016-07-16 2:13 ` [RFC][PATCH 5/7] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms John Stultz
2016-07-16 11:18 ` Mark Brown
2016-07-16 2:13 ` [RFC][PATCH 6/7] ASoC: hisilicon: Add hi6210 i2s audio driver for hdmi audio John Stultz
2016-07-16 11:44 ` Mark Brown
2016-07-19 21:59 ` John Stultz
2016-07-20 0:21 ` Mark Brown [this message]
2016-07-16 2:13 ` [PATCH 7/7] dts: hi6220: Add k3-dma and i2s/hdmi audio support John Stultz
2016-07-16 11:48 ` Mark Brown
2016-07-18 17:20 ` John Stultz
2016-07-16 3:15 ` [RFC][PATCH 0/7] Add HDMI audio support for HiKey Andy Green
2016-07-16 3:38 ` John Stultz
2016-07-16 11:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720002118.GA6509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.long@linaro.org \
--cc=guodong.xu@linaro.org \
--cc=jg1.han@samsung.com \
--cc=john.stultz@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.