From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] doc: note a pitfall on reconnect feature
Date: Wed, 20 Jul 2016 09:08:35 +0800
Message-ID: <20160720010835.GO5146@yliu-dev.sh.intel.com>
References: <1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com>
 <B27915DBBA3421428155699D51E4CFE2025A310C@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 5F53F376C
 for <dev@dpdk.org>; Wed, 20 Jul 2016 03:05:06 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025A310C@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 19, 2016 at 01:57:11PM +0000, Mcnamara, John wrote:
> > -  Note: the "reconnect" feature requires **QEMU v2.7** (or above).
> > +  .. Note::
> > +     * The "reconnect" feature requires **QEMU v2.7** (or above).
> > +
> > +     * The vhost supported features must be exactly the same before and
> > +       after the restart. For example, if TSO is disabled and then
> > enabled,
> > +       nothing will work and issues undefined might happen.
> 
> s/ issues undefined / undefined issues /

Thomas, mind to fix it while apply?

> Apart from that:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Thanks!

	--yliu