From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: <linux-kernel@vger.kernel.org>, <myungjoo.ham@samsung.com>,
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/4] extcon: arizona: Remove the usage of extcon_update_state()
Date: Wed, 20 Jul 2016 09:22:42 +0100 [thread overview]
Message-ID: <20160720082242.GA8680@localhost.localdomain> (raw)
In-Reply-To: <1469000327-15615-2-git-send-email-cw00.choi@samsung.com>
On Wed, Jul 20, 2016 at 04:38:44PM +0900, Chanwoo Choi wrote:
> This patch remvoes the usage of extcon_update_state() because
> the extcon_update_state() use directly the bit masking calculation
> to change the state of external connector without the unique id of
> external connector. It makes the code diffcult to read it.
> So, this patch uses the extcon_set_cable_state_() instead.
>
> Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Cc: patches@opensource.wolfsonmicro.com
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2016-07-20 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 7:38 [PATCH 0/4] extcon: Block the usgae of extcon_set/get/update_state() except for extcon core Chanwoo Choi
2016-07-20 7:38 ` [PATCH 1/4] extcon: arizona: Remove the usage of extcon_update_state() Chanwoo Choi
2016-07-20 8:22 ` Charles Keepax [this message]
2016-07-20 7:38 ` [PATCH 2/4] extcon: adc-jack: Remove the usage of extcon_set_state() Chanwoo Choi
2016-07-20 7:38 ` [PATCH 3/4] extcon: Remove the state_store() to prevent the wrong access Chanwoo Choi
2016-07-20 7:38 ` [PATCH 4/4] extcon: Block the bit masking operation for cable state except for extcon core Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720082242.GA8680@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.