From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPnA3-0001ql-2U for qemu-devel@nongnu.org; Wed, 20 Jul 2016 04:47:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPn9y-0005zT-Av for qemu-devel@nongnu.org; Wed, 20 Jul 2016 04:47:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPn9y-0005zM-2c for qemu-devel@nongnu.org; Wed, 20 Jul 2016 04:47:18 -0400 Date: Wed, 20 Jul 2016 09:47:13 +0100 From: "Daniel P. Berrange" Message-ID: <20160720084713.GE29602@redhat.com> Reply-To: "Daniel P. Berrange" References: <1468950439-16259-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Fix regressions caused by renaming README List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Stefan Weil , QEMU Developer , Pranith Kumar , Paolo Bonzini On Tue, Jul 19, 2016 at 09:53:30PM +0100, Peter Maydell wrote: > On 19 July 2016 at 18:47, Stefan Weil wrote: > > Commit e5dfc5e8e715c572aea44ac4d96c43941d4741c7 renamed README but did not > > update scripts/checkpatch.pl. Fix this. > > > > An update was also needed for qemu.nsi (Windows). > > > > Reported-by: Daniel P. Berrange > > Signed-off-by: Stefan Weil > > --- > > qemu.nsi | 4 ++-- > > scripts/checkpatch.pl | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/qemu.nsi b/qemu.nsi > > index a20f6ef..c037017 100644 > > --- a/qemu.nsi > > +++ b/qemu.nsi > > @@ -116,7 +116,7 @@ Section "${PRODUCT} (required)" > > File "${SRCDIR}\Changelog" > > File "${SRCDIR}\COPYING" > > File "${SRCDIR}\COPYING.LIB" > > - File "${SRCDIR}\README" > > + File "${SRCDIR}\README.md" > > File "${SRCDIR}\VERSION" > > > > File "${BINDIR}\*.bmp" > > @@ -206,7 +206,7 @@ Section "Uninstall" > > Delete "$INSTDIR\Changelog" > > Delete "$INSTDIR\COPYING" > > Delete "$INSTDIR\COPYING.LIB" > > - Delete "$INSTDIR\README" > > + Delete "$INSTDIR\README.md" > > Delete "$INSTDIR\VERSION" > > Delete "$INSTDIR\*.bmp" > > Delete "$INSTDIR\*.bin" > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index afa7f79..8247305 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -286,7 +286,7 @@ sub top_of_kernel_tree { > > > > my @tree_check = ( > > "COPYING", "MAINTAINERS", "Makefile", > > - "README", "docs", "VERSION", > > + "README.md", "docs", "VERSION", > > "vl.c" > > ); > > Does raise the question of whether we should be renaming > the file in the first place. README is the traditional > name and fits with all our other basically-plain-text > document names like COPYING, MAINTAINERS, HACKING. As mentioned in my original review, we could just create a symlink between READE & README.md or vica-verca if we wish to preserve the "normal" filename, but still have github do its magic. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|