From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpatch.pl
Date: Wed, 20 Jul 2016 11:42:19 +0100 [thread overview]
Message-ID: <20160720104219.GI29602@redhat.com> (raw)
In-Reply-To: <CAFEAcA-wvdjGw843KHSRoSE2QXJt8r9pcqWbNX08qURgygKtXg@mail.gmail.com>
On Wed, Jul 20, 2016 at 11:36:36AM +0100, Peter Maydell wrote:
> On 20 July 2016 at 08:27, Fam Zheng <famz@redhat.com> wrote:
> > Commit e5dfc5e8e71 renamed README to README.md but scripts/checkpatch.pl
> > still looks for the old name to sanity check that it's invoked from the
> > toplevel of tree.
> >
> > Create a symbol link to README.md to fix that. I've verified that on
> > github README.md still takes precedence and page is rendered.
>
> Have you checked that the symlink does sensible things if the git
> tree is checked out under Windows?
Should be fine
https://www.kernel.org/pub/software/scm/git/docs/git-config.html
"core.symlinks
If false, symbolic links are checked out as small plain files that
contain the link text. git-update-index(1) and git-add(1) will not
change the recorded type to regular file. Useful on filesystems like
FAT that do not support symbolic links.
The default is true, except git-clone(1) or git-init(1) will probe
and set core.symlinks false if appropriate when the repository is
created."
IOW, git will just "do the right thing" and automatically default
core.symlinks to false on FAT.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-07-20 10:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 7:27 [Qemu-devel] [PATCH] Symlink README.md as README to unbreak checkpatch.pl Fam Zheng
2016-07-20 9:16 ` Stefan Hajnoczi
2016-07-20 10:36 ` Peter Maydell
2016-07-20 10:42 ` Daniel P. Berrange [this message]
2016-07-20 10:48 ` Stefan Weil
2016-07-20 12:31 ` Eric Blake
2016-07-20 18:07 ` John Snow
2016-07-20 18:35 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720104219.GI29602@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=bobby.prani@gmail.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.