All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options
Date: Wed, 20 Jul 2016 17:38:36 +0200	[thread overview]
Message-ID: <20160720153836.GS7132@piout.net> (raw)
In-Reply-To: <CAHQ1cqEoN7PEQApHBo-FOqumtLJWoURHOPZfrzL=6h2p4S0Fdg@mail.gmail.com>

On 20/07/2016 at 07:36:55 -0700, Andrey Smirnov wrote :
> On Wed, Jul 20, 2016 at 2:02 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > On 19/07/2016 at 16:56:56 -0700, Andrey Smirnov wrote :
> >> >> I don't see any value in doing that, could you give me a realistic
> >> >> example of a scenario in which a user would want to spend some of
> >> >> uptime with RTC oscillator fault detection/glitch filtering disabled
> >> >> and then enable it?
> >> >>
> >> >
> >> > Well, the issue is not being dynamic, it is differentiating between
> >> > hardware description and user configuration. Configuration must not be in
> >> > DT.
> >>
> >> Why? And I don't mean in a generic sense, but in this particular case.
> >> What is gained by not having this bit of configuration, whose only
> >> consumer is the driver, in the device tree file?
> >>
> >
> > Because configuration doesn't belong to DT. DT is about hardware
> > description, not configuration.
> 
> That doesn't really answer my question. You just re-iterating some
> maxim without explaining what is the point behind applying it.
> 

Well, that is from the device tree specification and how the device tree
maintainers want it...

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Andrey Smirnov <andrew.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options
Date: Wed, 20 Jul 2016 17:38:36 +0200	[thread overview]
Message-ID: <20160720153836.GS7132@piout.net> (raw)
In-Reply-To: <CAHQ1cqEoN7PEQApHBo-FOqumtLJWoURHOPZfrzL=6h2p4S0Fdg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 20/07/2016 at 07:36:55 -0700, Andrey Smirnov wrote :
> On Wed, Jul 20, 2016 at 2:02 AM, Alexandre Belloni
> <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > On 19/07/2016 at 16:56:56 -0700, Andrey Smirnov wrote :
> >> >> I don't see any value in doing that, could you give me a realistic
> >> >> example of a scenario in which a user would want to spend some of
> >> >> uptime with RTC oscillator fault detection/glitch filtering disabled
> >> >> and then enable it?
> >> >>
> >> >
> >> > Well, the issue is not being dynamic, it is differentiating between
> >> > hardware description and user configuration. Configuration must not be in
> >> > DT.
> >>
> >> Why? And I don't mean in a generic sense, but in this particular case.
> >> What is gained by not having this bit of configuration, whose only
> >> consumer is the driver, in the device tree file?
> >>
> >
> > Because configuration doesn't belong to DT. DT is about hardware
> > description, not configuration.
> 
> That doesn't really answer my question. You just re-iterating some
> maxim without explaining what is the point behind applying it.
> 

Well, that is from the device tree specification and how the device tree
maintainers want it...

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options
Date: Wed, 20 Jul 2016 17:38:36 +0200	[thread overview]
Message-ID: <20160720153836.GS7132@piout.net> (raw)
In-Reply-To: <CAHQ1cqEoN7PEQApHBo-FOqumtLJWoURHOPZfrzL=6h2p4S0Fdg@mail.gmail.com>

On 20/07/2016 at 07:36:55 -0700, Andrey Smirnov wrote :
> On Wed, Jul 20, 2016 at 2:02 AM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > On 19/07/2016 at 16:56:56 -0700, Andrey Smirnov wrote :
> >> >> I don't see any value in doing that, could you give me a realistic
> >> >> example of a scenario in which a user would want to spend some of
> >> >> uptime with RTC oscillator fault detection/glitch filtering disabled
> >> >> and then enable it?
> >> >>
> >> >
> >> > Well, the issue is not being dynamic, it is differentiating between
> >> > hardware description and user configuration. Configuration must not be in
> >> > DT.
> >>
> >> Why? And I don't mean in a generic sense, but in this particular case.
> >> What is gained by not having this bit of configuration, whose only
> >> consumer is the driver, in the device tree file?
> >>
> >
> > Because configuration doesn't belong to DT. DT is about hardware
> > description, not configuration.
> 
> That doesn't really answer my question. You just re-iterating some
> maxim without explaining what is the point behind applying it.
> 

Well, that is from the device tree specification and how the device tree
maintainers want it...

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-07-20 15:38 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  5:59 [rtc-linux] [PATCH 00/13] DS1341 support and code cleanup Andrey Smirnov
2016-06-15  5:59 ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 01/13] RTC: ds1307: Add DS1341 variant Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 02/13] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-19 14:29   ` [rtc-linux] " Rob Herring
2016-06-19 14:29     ` Rob Herring
2016-06-19 14:29     ` Rob Herring
2016-06-19 18:12     ` [rtc-linux] " Andrey Smirnov
2016-06-19 18:12       ` Andrey Smirnov
2016-06-19 18:12       ` Andrey Smirnov
2016-06-21 20:49       ` [rtc-linux] " Rob Herring
2016-06-21 20:49         ` Rob Herring
2016-06-21 20:49         ` Rob Herring
2016-06-21 21:07         ` [rtc-linux] " Alexandre Belloni
2016-06-21 21:07           ` Alexandre Belloni
2016-06-21 21:07           ` Alexandre Belloni
2016-06-22  2:34           ` [rtc-linux] " Andrey Smirnov
2016-06-22  2:34             ` Andrey Smirnov
2016-06-22  2:34             ` Andrey Smirnov
2016-07-12 16:21             ` [rtc-linux] " Andrey Smirnov
2016-07-12 16:21               ` Andrey Smirnov
2016-07-12 16:21               ` Andrey Smirnov
2016-07-19 22:47             ` [rtc-linux] " Alexandre Belloni
2016-07-19 22:47               ` Alexandre Belloni
2016-07-19 22:47               ` Alexandre Belloni
2016-07-19 23:56               ` [rtc-linux] " Andrey Smirnov
2016-07-19 23:56                 ` Andrey Smirnov
2016-07-19 23:56                 ` Andrey Smirnov
2016-07-20  9:02                 ` [rtc-linux] " Alexandre Belloni
2016-07-20  9:02                   ` Alexandre Belloni
2016-07-20 14:36                   ` [rtc-linux] " Andrey Smirnov
2016-07-20 14:36                     ` Andrey Smirnov
2016-07-20 14:36                     ` Andrey Smirnov
2016-07-20 15:38                     ` Alexandre Belloni [this message]
2016-07-20 15:38                       ` Alexandre Belloni
2016-07-20 15:38                       ` Alexandre Belloni
2016-07-20 16:11                       ` [rtc-linux] " Andrey Smirnov
2016-07-20 16:11                         ` Andrey Smirnov
2016-07-20 16:11                         ` Andrey Smirnov
2016-06-21 23:23         ` [rtc-linux] " Andrey Smirnov
2016-06-21 23:23           ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 04/13] RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 05/13] RTC: ds1307: Convert want_irq " Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 06/13] RTC: ds1307: Move chip configuration into a separate routine Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 07/13] RTC: ds1307: Move chip sanity checking " Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 08/13] RTC: ds1307: Remove register "cache" Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 09/13] RTC: ds1307: Constify struct ds1307 where possible Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 10/13] RTC: ds1307: Convert goto to a loop Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 11/13] RTC: ds1307: Redefine RX8025_REG_* to minimize extra code Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 12/13] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov
2016-06-15  5:59 ` [rtc-linux] [PATCH 13/13] RTC: ds1307: Move last bits of sanity checking out of chip_configure Andrey Smirnov
2016-06-15  5:59   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160720153836.GS7132@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=andrew.smirnov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.