From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC ABI V2 6/8] RDMA/core: Add initialize and cleanup of common types Date: Wed, 20 Jul 2016 11:40:52 -0600 Message-ID: <20160720174052.GI21460@obsidianresearch.com> References: <1468941812-32286-1-git-send-email-matanb@mellanox.com> <1468941812-32286-7-git-send-email-matanb@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1468941812-32286-7-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matan Barak Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford , Sean Hefty , Liran Liss , Haggai Eran , Tal Alon , Majd Dibbiny , Christoph Lameter , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Tue, Jul 19, 2016 at 06:23:30PM +0300, Matan Barak wrote: > @@ -210,103 +211,9 @@ static void ib_uverbs_detach_umcast(struct ib_qp *qp, > static int ib_uverbs_cleanup_ucontext(struct ib_uverbs_file *file, > struct ib_ucontext *context) > { > + ib_uverbs_uobject_type_initialize_ucontext(context, &file->device->ib_dev->type_list); There is a certain dissonance to having an initialize function called inside a cleanup function - is that right (it doesn't look that right)? If it is right, find a better name... Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html