Re: [PATCH nft] ct: use nftables sysconf location for connlabel configuration

[Florian Westphal <fw@strlen.de>]

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Jul 20, 2016 at 12:17:05PM +0200, Florian Westphal wrote:
> > Instead of using /etc/xtables use the nftables syconfdir.
> > Also update error message to tell which label failed translation
> > and which config file was used for this:
> > 
> > nft add filter input ct label foo
> > <cmdline>:1:27-29: Error: /etc/nftables/connlabel.conf: could not parse conntrack label "foo"
> > 
> > Suggested-by: Pablo Neira Ayuso <pablo@netfilter.org>
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> > ---
> >  src/Makefile.am | 2 ++
> >  src/ct.c        | 7 +++++--
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 8c59449..ff1dd6e 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -27,6 +27,8 @@ parser_bison.o scanner.o: AM_CFLAGS += -Wno-missing-prototypes -Wno-missing-decl
> >  
> >  BUILT_SOURCES = parser_bison.h
> >  
> > +ct.o: AM_CFLAGS += -DCONNLABEL_PATH="\"${sysconfdir}/\""
> 
> I think we can simplify this by using DEFAULT_INCLUDE_PATH.
> 
> See patch attached, it applies on top of this one. Feel free to
> collapse them.

Okay, I pushed it to nftables.git (with your patch collapsed).