From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Damien Le Moal <damien.lemoal@hgst.com>
Subject: Re: [PATCH 5/6] block: Introduce BLKPREP_DONE
Date: Wed, 20 Jul 2016 22:58:57 -0700 [thread overview]
Message-ID: <20160721055857.GC14568@infradead.org> (raw)
In-Reply-To: <1468934439-93579-6-git-send-email-hare@suse.de>
> +++ b/block/blk-core.c
> @@ -2462,9 +2462,13 @@ struct request *blk_peek_request(struct request_queue *q)
>
> rq = NULL;
> break;
> - } else if (ret == BLKPREP_KILL || ret == BLKPREP_INVALID) {
> + } else if (ret == BLKPREP_KILL || ret == BLKPREP_INVALID ||
> + ret == BLKPREP_DONE) {
> int err = (ret == BLKPREP_INVALID) ? -EREMOTEIO : -EIO;
>
> + if (ret == BLKPREP_DONE)
> + err = 0;
> +
Please just use a proper switch statement for the return values.
static void blk_prep_end_request(struct request *req, int error)
{
rq->cmd_flags |= REQ_QUIET;
blk_start_request(rq);
__blk_end_request_all(rq, error);
}
struct request *blk_peek_request(struct request_queue *q)
{
...
switch (ret) {
...
case BLKPREP_KILL:
blk_prep_end_request(rq, -EIO);
break;
case BLKPREP_INVALID:
blk_prep_end_request(rq, -EREMOTEIO);
break;
case BLKPREP_DONE:
blk_prep_end_request(rq, 0);
break;
...
}
next prev parent reply other threads:[~2016-07-21 5:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 13:20 [PATCH 0/6] Support for zoned block devices Hannes Reinecke
2016-07-19 13:20 ` [PATCH 1/6] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Hannes Reinecke
2016-07-20 1:02 ` Damien Le Moal
2016-07-20 1:02 ` Damien Le Moal
2016-07-21 5:59 ` Christoph Hellwig
2016-07-22 20:35 ` Martin K. Petersen
2016-07-19 13:20 ` [PATCH 2/6] block: update chunk_sectors in blk_stack_limits() Hannes Reinecke
2016-07-20 1:05 ` Damien Le Moal
2016-07-20 1:05 ` Damien Le Moal
2016-07-21 5:59 ` Christoph Hellwig
2016-07-22 20:46 ` Martin K. Petersen
2016-07-19 13:20 ` [PATCH 3/6] block: Implement support for zoned block devices Hannes Reinecke
2016-07-20 1:05 ` Damien Le Moal
2016-07-20 1:05 ` Damien Le Moal
2016-07-19 13:20 ` [PATCH 4/6] block: Add 'zoned' sysfs queue attribute Hannes Reinecke
2016-07-20 1:07 ` Damien Le Moal
2016-07-20 1:07 ` Damien Le Moal
2016-07-22 20:45 ` Martin K. Petersen
2016-07-23 12:43 ` Hannes Reinecke
2016-07-23 12:43 ` Hannes Reinecke
2016-07-23 22:13 ` Bart Van Assche
2016-07-23 22:13 ` Bart Van Assche
2016-07-24 7:10 ` Hannes Reinecke
2016-07-24 7:10 ` Hannes Reinecke
2016-07-24 13:37 ` Bart Van Assche
2016-07-24 13:37 ` Bart Van Assche
2016-07-24 13:51 ` Bart Van Assche
2016-07-24 23:22 ` Damien Le Moal
2016-07-25 5:56 ` Hannes Reinecke
2016-07-25 5:56 ` Hannes Reinecke
2016-07-25 14:45 ` Jens Axboe
2016-07-24 23:16 ` Damien Le Moal
2016-07-25 14:44 ` Jens Axboe
2016-07-19 13:20 ` [PATCH 5/6] block: Introduce BLKPREP_DONE Hannes Reinecke
2016-07-20 1:10 ` Damien Le Moal
2016-07-20 1:10 ` Damien Le Moal
2016-07-21 5:58 ` Christoph Hellwig [this message]
2016-07-21 6:01 ` Hannes Reinecke
2016-07-21 6:01 ` Hannes Reinecke
2016-07-19 13:20 ` [PATCH 6/6] block: Add 'BLK_MQ_RQ_QUEUE_DONE' return value Hannes Reinecke
2016-07-20 1:11 ` Damien Le Moal
2016-07-20 1:11 ` Damien Le Moal
2016-07-21 5:53 ` Christoph Hellwig
2016-07-21 6:00 ` Hannes Reinecke
2016-07-21 6:00 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721055857.GC14568@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=damien.lemoal@hgst.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.