Re: [RFC ABI V2 1/8] RDMA/core: Export RDMA IOCTL declarations

[Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

On Thu, Jul 21, 2016 at 01:07:19AM -0700, Christoph Hellwig wrote:
> On Tue, Jul 19, 2016 at 06:23:25PM +0300, Matan Barak wrote:
> > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > 
> > Place all external RDMA IOCTL declarations into one UAPI exported
> > header file and move all legacy MAD commands to that file.
> 
> FYI, we also need to have all the structures used for the UAPI in
> a uapi header.  I started on that a while ago, but it needs to be
> resurrected.  Given that you're busy in this area it might be a good
> idea if you pick this work up:
> 
> http://git.infradead.org/users/hch/rdma.git/shortlog/refs/heads/rdma-uapi
> 
> > +#ifndef RDMA_IOCTL_H
> > +#define RDMA_IOCTL_H
> > +
> > +#include <rdma/rdma_user_ioctl.h>
> > +
> > +#endif /* RDMA_IOCTL_H */
> 
> What's the point of this wrappers?  Either way no need to include
> guards for a no-op header if it will be kept around for some reason.

I dropped this file, it is not needed.

> 
> > +/*
> > + * For hfi1 driver
> > + */
> > +#define IB_IOCTL_MAGIC			RDMA_IOCTL_MAGIC
> > +
> > +/* Legacy part
> > + * !!!! NOTE: It uses the same command index as VERBS
> > + */
> 
> In that case it should be in the same header just to avoid confusion.

I prepared proper series for this stuff and will send next week.

Thanks

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]