From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] vhost: fix connect hang in client mode Date: Thu, 21 Jul 2016 20:35:24 +0800 Message-ID: <20160721123524.GG28708@yliu-dev.sh.intel.com> References: <1469089275-15209-1-git-send-email-i.maximets@samsung.com> <20160721093714.GD28708@yliu-dev.sh.intel.com> <579099BC.9050603@samsung.com> <20160721101311.GE28708@yliu-dev.sh.intel.com> <5790A5D4.1090703@samsung.com> <5790AEB3.2010708@samsung.com> <20160721114016.GF28708@yliu-dev.sh.intel.com> <5790BBA7.6070202@samsung.com> <5790BC5A.2010505@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Huawei Xie , Dyasly Sergey , Heetae Ahn , Thomas Monjalon To: Ilya Maximets Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CFE68968 for ; Thu, 21 Jul 2016 14:31:17 +0200 (CEST) Content-Disposition: inline In-Reply-To: <5790BC5A.2010505@samsung.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: > >> > >> What do you think of it? > > > > I found that we can't check connection status without select/poll > > on it. 'getsockopt()' will return 0 with no errors if connection > > is not still established just like if it was. > > So, I think, the first version of this patch is the only > > acceptable solution. > > Sorry, v2 is acceptable too, because it always calls 'connect()'. So you have done the test that it works? I'm more curious to know could your above case hit the getsockopt() code path, I mean, the path that errno is set to EINPROGRESS or EISCONN? --yliu