From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 02/12] virtio: setup and start cq in configure callback Date: Thu, 21 Jul 2016 14:15:43 -0700 Message-ID: <20160721141543.3da73f64@xeon-e3> References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1469088510-7552-3-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, yuanhan.liu@linux.intel.com, konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com To: Olivier Matz Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 5ECB8590B for ; Thu, 21 Jul 2016 23:15:29 +0200 (CEST) Received: by mail-pa0-f51.google.com with SMTP id ks6so32521036pab.0 for ; Thu, 21 Jul 2016 14:15:29 -0700 (PDT) In-Reply-To: <1469088510-7552-3-git-send-email-olivier.matz@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 21 Jul 2016 10:08:20 +0200 Olivier Matz wrote: > + dev_info->max_rx_queues = (uint16_t) > + ((VIRTIO_MAX_RX_QUEUES < hw->max_queue_pairs) ? > + VIRTIO_MAX_RX_QUEUES : hw->max_queue_pairs); > + dev_info->max_tx_queues = (uint16_t) > + ((VIRTIO_MAX_TX_QUEUES < hw->max_queue_pairs) ? > + VIRTIO_MAX_TX_QUEUES : hw->max_queue_pairs); cast here was always unnecessary. Why not use RTE_MIN()