From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1 Date: Thu, 21 Jul 2016 14:24:51 +0100 Message-ID: <20160721142451.2ee990ce@arm.com> References: <1468933014-26966-1-git-send-email-marc.zyngier@arm.com> <20160721131720.GA32739@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160721131720.GA32739@potion> Sender: kvm-owner@vger.kernel.org To: Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Christoffer Dall , Paolo Bonzini , Tirumalesh Chalamarla List-Id: kvmarm@lists.cs.columbia.edu On Thu, 21 Jul 2016 15:17:20 +0200 Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: Hi Radim, > 2016-07-19 13:56+0100, Marc Zyngier: > > The kprobe enablement work has uncovered that changes made by > > a guest to MDSCR_EL1 were propagated to the host when VHE was > > enabled, leading to unexpected exception being delivered. > >=20 > > Moving this register to the list of registers that are always > > context-switched fixes the issue. > >=20 > > Fixes: 9c6c35683286 ("arm64: KVM: VHE: Split save/restore of regist= ers shared between guest and host") > > Cc: stable@vger.kernel.org #4.6 > > Reported-by: Tirumalesh Chalamarla > > Tested-by: Tirumalesh Chalamarla > > Signed-off-by: Marc Zyngier > > --- =20 >=20 > I would take this patch to 4.7 directly through the main tree. > Are your plans different? If you're happy to take it now, that works for me. I can either send a PR right away, or you can apply it directly, whichever works best for you. Thanks, M. --=20 Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Thu, 21 Jul 2016 14:24:51 +0100 Subject: [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1 In-Reply-To: <20160721131720.GA32739@potion> References: <1468933014-26966-1-git-send-email-marc.zyngier@arm.com> <20160721131720.GA32739@potion> Message-ID: <20160721142451.2ee990ce@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 21 Jul 2016 15:17:20 +0200 Radim Kr?m?? wrote: Hi Radim, > 2016-07-19 13:56+0100, Marc Zyngier: > > The kprobe enablement work has uncovered that changes made by > > a guest to MDSCR_EL1 were propagated to the host when VHE was > > enabled, leading to unexpected exception being delivered. > > > > Moving this register to the list of registers that are always > > context-switched fixes the issue. > > > > Fixes: 9c6c35683286 ("arm64: KVM: VHE: Split save/restore of registers shared between guest and host") > > Cc: stable at vger.kernel.org #4.6 > > Reported-by: Tirumalesh Chalamarla > > Tested-by: Tirumalesh Chalamarla > > Signed-off-by: Marc Zyngier > > --- > > I would take this patch to 4.7 directly through the main tree. > Are your plans different? If you're happy to take it now, that works for me. I can either send a PR right away, or you can apply it directly, whichever works best for you. Thanks, M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v2] arm64: KVM: VHE: Context switch MDSCR_EL1 Date: Thu, 21 Jul 2016 14:24:51 +0100 Message-ID: <20160721142451.2ee990ce@arm.com> References: <1468933014-26966-1-git-send-email-marc.zyngier@arm.com> <20160721131720.GA32739@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , , , Christoffer Dall , Paolo Bonzini , Tirumalesh Chalamarla To: Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= Return-path: Received: from foss.arm.com ([217.140.101.70]:48228 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbcGUNY5 convert rfc822-to-8bit (ORCPT ); Thu, 21 Jul 2016 09:24:57 -0400 In-Reply-To: <20160721131720.GA32739@potion> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 21 Jul 2016 15:17:20 +0200 Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: Hi Radim, > 2016-07-19 13:56+0100, Marc Zyngier: > > The kprobe enablement work has uncovered that changes made by > > a guest to MDSCR_EL1 were propagated to the host when VHE was > > enabled, leading to unexpected exception being delivered. > >=20 > > Moving this register to the list of registers that are always > > context-switched fixes the issue. > >=20 > > Fixes: 9c6c35683286 ("arm64: KVM: VHE: Split save/restore of regist= ers shared between guest and host") > > Cc: stable@vger.kernel.org #4.6 > > Reported-by: Tirumalesh Chalamarla > > Tested-by: Tirumalesh Chalamarla > > Signed-off-by: Marc Zyngier > > --- =20 >=20 > I would take this patch to 4.7 directly through the main tree. > Are your plans different? If you're happy to take it now, that works for me. I can either send a PR right away, or you can apply it directly, whichever works best for you. Thanks, M. --=20 Jazz is not dead. It just smells funny.