All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Vinson Lee <vlee@freedesktop.org>
Cc: trinity@vger.kernel.org
Subject: Re: [PATCH v2] Fix build on older kernels without BPF.
Date: Thu, 21 Jul 2016 16:10:48 -0400	[thread overview]
Message-ID: <20160721201048.GA9384@codemonkey.org.uk> (raw)
In-Reply-To: <1468359236-6940-1-git-send-email-vlee@freedesktop.org>

On Tue, Jul 12, 2016 at 09:33:56PM +0000, Vinson Lee wrote:
 > Suggested-by: Dave Jones <davej@codemonkey.org.uk>
 > Signed-off-by: Vinson Lee <vlee@freedesktop.org>

Close, but..

 > diff --git a/include/syscalls-aarch64.h b/include/syscalls-aarch64.h
 > index 09acf41..ee18c64 100644
 > --- a/include/syscalls-aarch64.h
 > +++ b/include/syscalls-aarch64.h
 > @@ -290,6 +290,8 @@ struct syscalltable syscalls_aarch64[] = {
 >  /* 277 */	{ .entry = &syscall_seccomp },
 >  /* 278 */	{ .entry = &syscall_getrandom },
 >  /* 279 */	{ .entry = &syscall_memfd_create },
 > +#ifdef USE_BPF
 >  /* 280 */	{ .entry = &syscall_bpf },
 > +#endif
 >  /* 281 */	{ .entry = &syscall_execveat },
 >  };

You need an

#else
	NULL,

for each of these, otherwise the next syscall will be in the wrong slot.

	Dave

  reply	other threads:[~2016-07-21 20:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 18:43 [PATCH] Fix build on older kernels without BPF Vinson Lee
2016-07-12 19:02 ` Dave Jones
2016-07-12 21:33   ` [PATCH v2] " Vinson Lee
2016-07-21 20:10     ` Dave Jones [this message]
2016-07-26  0:24       ` Vinson Lee
2016-07-26  0:59         ` Dave Jones
2016-08-04 20:36           ` Dave Jones
2016-08-05 18:44             ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721201048.GA9384@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=trinity@vger.kernel.org \
    --cc=vlee@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.