From: Viresh Kumar <viresh.kumar@linaro.org>
To: Steve Muckle <steve.muckle@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Juri Lelli <Juri.Lelli@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Steve Muckle <smuckle@linaro.org>
Subject: Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq()
Date: Thu, 21 Jul 2016 14:13:44 -0700 [thread overview]
Message-ID: <20160721211344.GJ3122@ubuntu> (raw)
In-Reply-To: <1468441527-23534-2-git-send-email-smuckle@linaro.org>
On 13-07-16, 13:25, Steve Muckle wrote:
> +unsigned int cpufreq_driver_resolve_freq(struct cpufreq_policy *policy,
> + unsigned int target_freq)
> +{
> + target_freq = clamp_val(target_freq, policy->min, policy->max);
> + policy->cached_target_freq = target_freq;
> + if (cpufreq_driver->resolve_freq)
> + return cpufreq_driver->resolve_freq(policy, target_freq);
> + policy->cached_resolved_idx =
> + cpufreq_frequency_table_target(policy, target_freq,
> + CPUFREQ_RELATION_L);
> + return policy->freq_table[policy->cached_resolved_idx].frequency;
FWIW, this may crash the kernel for a driver that provides ->target()
but no ->resolve_freq().
--
viresh
next prev parent reply other threads:[~2016-07-21 21:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 20:25 [PATCH v3 0/3] cpufreq: avoid redundant driver calls in schedutil Steve Muckle
2016-07-13 20:25 ` [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle
2016-07-21 19:59 ` Viresh Kumar
2016-07-21 20:31 ` Rafael J. Wysocki
2016-07-21 20:30 ` Viresh Kumar
2016-07-21 20:52 ` Rafael J. Wysocki
2016-07-21 20:52 ` Viresh Kumar
2016-07-21 21:19 ` Rafael J. Wysocki
2016-07-21 21:16 ` Viresh Kumar
2016-07-21 23:21 ` Steve Muckle
2016-07-21 23:29 ` Steve Muckle
2016-07-21 23:31 ` Viresh Kumar
2016-07-21 23:30 ` Viresh Kumar
2016-07-21 23:36 ` Steve Muckle
2016-07-21 23:41 ` Steve Muckle
2016-07-22 0:44 ` Steve Muckle
2016-07-22 15:16 ` Viresh Kumar
2016-07-22 17:49 ` Steve Muckle
2016-07-21 21:13 ` Viresh Kumar [this message]
2016-07-13 20:25 ` [PATCH v3 2/3] cpufreq: schedutil: map raw required frequency to driver frequency Steve Muckle
2016-07-13 20:25 ` [PATCH v3 3/3] cpufreq: acpi-cpufreq: use cached frequency mapping when possible Steve Muckle
2016-07-14 10:02 ` [PATCH v3 0/3] cpufreq: avoid redundant driver calls in schedutil Pingbo Wen
2016-07-14 18:00 ` Steve Muckle
2016-07-21 20:01 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721211344.GJ3122@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=smuckle@linaro.org \
--cc=steve.muckle@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.