From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [XTF PATCH v2 4/4] xtf-runner: regularise runner exit code
Date: Fri, 22 Jul 2016 10:58:04 +0100 [thread overview]
Message-ID: <20160722095804.GI927@citrix.com> (raw)
In-Reply-To: <20160722095148.GH927@citrix.com>
Updated this patch
---8<---
From ef1f9ddfa797bb4095d48b90efc3c92a0a8fd1b6 Mon Sep 17 00:00:00 2001
From: Wei Liu <wei.liu2@citrix.com>
Date: Mon, 13 Jun 2016 15:06:48 +0100
Subject: [XTF PATCH] xtf-runner: regularise runner exit code
Cc: andrew.cooper3@citrix.com
The script now returns the most severe result. Document the exit code in
help string.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
xtf-runner | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/xtf-runner b/xtf-runner
index 1c96750..7743316 100755
--- a/xtf-runner
+++ b/xtf-runner
@@ -251,14 +251,15 @@ def run_tests(args):
if not len(tests):
raise RunnerError("No tests to run")
- rc = 0
+ rc = all_results.index('SUCCESS')
results = []
for test in tests:
res = run_test(test)
- if res != "SUCCESS":
- rc = 1
+ res_idx = all_results.index(res);
+ if res_idx > rc:
+ rc = res_idx
results.append(res)
@@ -267,7 +268,7 @@ def run_tests(args):
for test, res in zip(tests, results):
print "%-40s %s" % (test, res)
- return rc
+ return exit_code(all_results[rc])
def main():
@@ -308,6 +309,13 @@ def main():
" List all 'functional' or 'special' tests\n"
" ./xtf-runner --list hvm64\n"
" List all 'hvm64' tests\n"
+ "\n"
+ " Exit code for this script:\n"
+ " 0: everything is ok\n"
+ " 1,2: reserved for python interpreter\n"
+ " 3: test(s) are skipped\n"
+ " 4: test(s) report error\n"
+ " 5: test(s) report failure\n"
),
)
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-22 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 9:43 [XTF PATCH v2 0/4] Runner exit code clean up Wei Liu
2016-07-22 9:43 ` [XTF PATCH v2 1/4] gitignore: ignore vim swp file Wei Liu
2016-07-22 9:43 ` [XTF PATCH v2 2/4] xtf-runner: sync all test results Wei Liu
2016-07-22 9:43 ` [XTF PATCH v2 3/4] xtf-runner: provide a set of exit codes for different results Wei Liu
2016-07-22 9:43 ` [XTF PATCH v2 4/4] xtf-runner: regularise runner exit code Wei Liu
2016-07-22 9:49 ` Andrew Cooper
2016-07-22 9:51 ` Wei Liu
2016-07-22 9:58 ` Wei Liu [this message]
2016-07-22 10:14 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722095804.GI927@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.