From: Eric Wong <e@80x24.org>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Git Mailing List <git@vger.kernel.org>,
git-for-windows <git-for-windows@googlegroups.com>
Subject: Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK
Date: Fri, 22 Jul 2016 19:31:56 +0000 [thread overview]
Message-ID: <20160722193156.GA30158@dcvr> (raw)
In-Reply-To: <28dbe3b0-7a16-1b87-3d59-b8c981fead7c@kdbg.org>
Johannes Sixt <j6t@kdbg.org> wrote:
> The previous commit introduced the first use of ENOTSOCK. This macro is
> not available on Windows. Define it as WSAENOTSOCK because that is the
> corresponding error value reported by the Windows versions of socket
> functions.
Thanks. I thought compat/poll/poll.c already used ENOTSOCK
but I was mislead by the #ifdefs :x
prev parent reply other threads:[~2016-07-22 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 20:59 [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK Johannes Sixt
2016-07-22 8:21 ` Johannes Schindelin
2016-07-22 19:28 ` Junio C Hamano
2016-07-23 8:02 ` Johannes Schindelin
2016-07-23 8:39 ` [PATCH v2 " Johannes Sixt
2016-07-22 19:31 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160722193156.GA30158@dcvr \
--to=e@80x24.org \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.