From: Lukas Wunner <lukas@wunner.de>
To: Amir Levy <amir.jer.levy@intel.com>
Cc: andreas.noever@gmail.com, gregkh@linuxfoundation.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
thunderbolt-linux@intel.com, mika.westerberg@intel.com,
tomas.winkler@intel.com
Subject: Re: [PATCH v4 5/7] thunderbolt: Networking state machine
Date: Mon, 25 Jul 2016 00:36:35 +0200 [thread overview]
Message-ID: <20160724223635.GA9516@wunner.de> (raw)
In-Reply-To: <1468836040-28043-6-git-send-email-amir.jer.levy@intel.com>
On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote:
> + const unique_id_be proto_uuid = APPLE_THUNDERBOLT_IP_PROTOCOL_UUID;
> +
> + if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid,
> + sizeof(proto_uuid)) != 0) {
You may want to use the uuid_be data type provided by <linux/uuid.h>
instead of rolling your own, as well as the helper uuid_be_cmp()
defined ibidem.
Thanks,
Lukas
next prev parent reply other threads:[~2016-07-24 22:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 10:00 [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy
2016-07-18 10:00 ` [PATCH v4 1/7] thunderbolt: Macro rename Amir Levy
2016-07-18 10:00 ` [PATCH v4 2/7] thunderbolt: Updating the register definitions Amir Levy
2016-07-26 7:39 ` Andreas Noever
2016-07-26 9:08 ` Levy, Amir (Jer)
2016-07-26 9:08 ` Levy, Amir (Jer)
2016-07-18 10:00 ` [PATCH v4 3/7] thunderbolt: Kconfig for Thunderbolt(TM) networking Amir Levy
2016-07-18 10:00 ` [PATCH v4 4/7] thunderbolt: Communication with the ICM (firmware) Amir Levy
2016-07-18 10:00 ` [PATCH v4 5/7] thunderbolt: Networking state machine Amir Levy
2016-07-24 22:36 ` Lukas Wunner [this message]
2016-07-27 7:30 ` Levy, Amir (Jer)
2016-07-18 10:00 ` [PATCH v4 6/7] thunderbolt: Networking transmit and receive Amir Levy
2016-07-18 10:00 ` [PATCH v4 7/7] thunderbolt: Networking doc Amir Levy
2016-07-19 17:14 ` [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking Joe Perches
2016-07-20 6:02 ` Levy, Amir (Jer)
2016-07-20 6:32 ` Joe Perches
2016-07-19 22:02 ` Bjorn Helgaas
2016-07-26 7:35 ` Andreas Noever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160724223635.GA9516@wunner.de \
--to=lukas@wunner.de \
--cc=amir.jer.levy@intel.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=thunderbolt-linux@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.