Re: [PATCH 1/2] systemd: use standard dependencies for xendriverdomain.service

[Wei Liu <wei.liu2@citrix.com>]

On Sun, Jul 24, 2016 at 09:26:57PM +0200, Marek Marczykowski-Górecki wrote:
> Having DefaultDependencies=no means it can be started before / is
> remounted read-write, which will result in various failures (to start
> with opening the log).
> Since "libxl: trigger attach events for devices attached before xl devd
> startup" it is no longer important to start it as early as possible,
> because it will process devices created before its startup.
> 
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

The reasoning makes sense.

Acked-by: Wei Liu <wei.liu2@citrix.com>

Also CC Rusty (author of this file)

> ---
>  tools/hotplug/Linux/systemd/xendriverdomain.service.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> index c0cd454..0afb54d 100644
> --- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> +++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> @@ -1,6 +1,5 @@
>  [Unit]
>  Description=Xen driver domain device daemon
> -DefaultDependencies=no
>  Requires=proc-xen.mount
>  After=proc-xen.mount
>  ConditionVirtualization=xen
> -- 
> 2.5.5



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel