From: Wei Liu <wei.liu2@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service
Date: Mon, 25 Jul 2016 10:27:47 +0100 [thread overview]
Message-ID: <20160725092746.GB1008@citrix.com> (raw)
In-Reply-To: <20160724192713.GB22529@mail-itl>
On Sun, Jul 24, 2016 at 09:27:13PM +0200, Marek Marczykowski-Górecki wrote:
> It is no longer required since xl devd use /dev/xen interface.
>
How would this unit work when there is no /dev/xen interface?
To be precise, we prefer /dev/xen interfaces whenever possible but there
is a fallback to /proc/xen. Note that a lot of other unit files have
this dependency on proc-xen.mount.
I'm inclined to say we should keep this dependency but I'm not sure if I
missed some obvious things.
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> ---
> tools/hotplug/Linux/systemd/xendriverdomain.service.in | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> index 0afb54d..a100309 100644
> --- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> +++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> @@ -1,7 +1,5 @@
> [Unit]
> Description=Xen driver domain device daemon
> -Requires=proc-xen.mount
> -After=proc-xen.mount
> ConditionVirtualization=xen
>
> [Service]
> --
> 2.5.5
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-25 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1469388272-22789-1-git-send-email-marmarek@invisiblethingslab.com>
2016-07-24 19:27 ` [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service Marek Marczykowski-Górecki
2016-07-25 9:27 ` Wei Liu [this message]
2016-07-25 9:30 ` Marek Marczykowski-Górecki
2016-07-25 9:34 ` Wei Liu
2016-07-25 9:40 ` Marek Marczykowski-Górecki
2016-07-25 9:45 ` Andrew Cooper
2016-07-25 9:49 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725092746.GB1008@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=marmarek@invisiblethingslab.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.