Re: [PATCH 1/3] mac802154: don't warn on unsupported frames

[Aristeu Rozanski <arozansk@redhat.com>]

Hi Alexander,
On Sat, Jul 23, 2016 at 02:46:28PM +0200, Alexander Aring wrote:
> agree, but this patch introduce a different stats handling right now. :-)

sorry, should have split both parts in different patches.

> This should be moved into ieee802154_deliver_skb, right before calling
> netif_rx(...);
> 
> The reason is because we have for "stats.rx_bytes" and
> "stats.rx_packets" a very clean definition what it means. It means, the
> frames hit a state where it is ready to put it into the packet-layer,
> this is what netif_rx is doing.
> 
> It's okay for me to add support for rx_frame_errors and also rx_dropped
> stuff. But with a very big warning that the meaning of such stats will
> be touched again later if we found some strategie where we we define
> what each stats attribute means. Also there exists subsystems which
> simple ignore these stats, because at userspace side you need always to
> lookup what the definition means and when we run such stats counters and
> when not and some subsystems don't care about that.

Fair enough, I'll redo the patch just removing the warning.
Thanks!

-- 
Aristeu