Re: ESRT failures ... was Re: [PATCH 04/11] efi: Add efi_memmap_init_late() for permanent EFI memmap

[Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]

On Fri, 22 Jul, at 09:31:20AM, Prarit Bhargava wrote:
> 
> Hmm ... maybe just a Dell specific quirk?

Quirks are best avoided at all costs, platform-specific quirks doubly
so because there are just so many in the EFI arena that maintaining
them all would be a nightmare.

Where possible we adopt a "most buggy implementation" approach to
compatibility, as a least common denominator.

Could you try this patch out? It's not a final version, but I'd just
like to see if anything else explodes when we start returning reserved
regions.

---

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 05509f3aaee8..9857796c4cd4 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -299,7 +299,8 @@ int __init efi_mem_desc_lookup(u64 phys_addr, efi_memory_desc_t *out_md)
 
 		if (!(md->attribute & EFI_MEMORY_RUNTIME) &&
 		    md->type != EFI_BOOT_SERVICES_DATA &&
-		    md->type != EFI_RUNTIME_SERVICES_DATA) {
+		    md->type != EFI_RUNTIME_SERVICES_DATA &&
+		    md->type != EFI_RESERVED_TYPE) {
 			early_memunmap(md, sizeof (*md));
 			continue;
 		}