From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRiYA-0003tz-Lv for qemu-devel@nongnu.org; Mon, 25 Jul 2016 12:16:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRiY8-0001nU-OJ for qemu-devel@nongnu.org; Mon, 25 Jul 2016 12:16:13 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:34600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRiY8-0001nD-Ih for qemu-devel@nongnu.org; Mon, 25 Jul 2016 12:16:12 -0400 Date: Mon, 25 Jul 2016 18:16:11 +0200 From: Aurelien Jarno Message-ID: <20160725161611.GA2074@aurel32.net> References: <1466740107-15042-1-git-send-email-rth@twiddle.net> <1466740107-15042-9-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466740107-15042-9-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v3 8/9] tcg: Include liveness info in the dumps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com On 2016-06-23 20:48, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > index fd92b06..3e4bc99 100644 > --- a/tcg/tcg.c > +++ b/tcg/tcg.c > @@ -1009,6 +1009,7 @@ void tcg_dump_ops(TCGContext *s) > const TCGOpDef *def; > const TCGArg *args; > TCGOpcode c; > + long pos = ftell(qemu_logfile); > Small additional note: ftell() doesn't work well when the logfile is the terminal. As such when not dumping to the file, the alignment is wrong. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net