All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform: don't return 0 from platform_get_irq[_byname]() on error
Date: Mon, 25 Jul 2016 09:45:29 -0700	[thread overview]
Message-ID: <20160725164529.GA7540@kroah.com> (raw)
In-Reply-To: <f92c8a76-a042-2af8-6e6b-24f93ed6ae52@cogentembedded.com>

On Mon, Jul 25, 2016 at 02:55:37PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 7/4/2016 1:04 AM, Sergei Shtylyov wrote:
> 
> > of_irq_get[_byname]() return 0 iff  irq_create_of_mapping() call fails.
> > Returning both  error code and 0 on failure is a sign of a misdesigned API,
> > it makes the failure check unnecessarily complex and error prone. We should
> > rely  on the platform IRQ resource in this case, not return 0,  especially
> > as 0 can be  a valid  IRQ resource too...
> > 
> > Fixes: aff008ad813c ("platform_get_irq: Revert to platform_get_resource if of_irq_get fails")
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > CC: stable@vger.kernel.org
> 
>    4.7 has been tagged now. Can I count on this patch getting to 4.8? Or at
> least some feedback given? :-/

I'll get to it after 4.8-rc1 is out, but ideally one of the of
developers would look at it, as I have no way to test this...

thanks,

greg k-h

      reply	other threads:[~2016-07-25 16:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03 22:04 [PATCH v2] platform: don't return 0 from platform_get_irq[_byname]() on error Sergei Shtylyov
2016-07-25 11:55 ` Sergei Shtylyov
2016-07-25 16:45   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160725164529.GA7540@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.