From: Bjorn Helgaas <helgaas@kernel.org>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: jingoohan1@gmail.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, jszhang@marvell.com,
CARLOS.PALMINHA@synopsys.com, MiguelFalcao.Sousa@synopsys.com
Subject: Re: [PATCH v2 2/2] pcie-designware: add core version
Date: Mon, 25 Jul 2016 15:16:13 -0500 [thread overview]
Message-ID: <20160725201613.GA15939@localhost> (raw)
In-Reply-To: <17d796c59a2b63a494d1695a4d04ed6fc9f93c0c.1469193895.git.jpinto@synopsys.com>
On Fri, Jul 22, 2016 at 02:29:39PM +0100, Joao Pinto wrote:
>
> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> ---
> changes v1->v2:
> - Nothing changed. Just to keep up the patch set version.
>
> drivers/pci/host/pcie-designware.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 9135725..3e4c600 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -34,6 +34,10 @@
> #define LINK_WAIT_IATU_MIN 9000
> #define LINK_WAIT_IATU_MAX 10000
>
> +/* Core version (available from core 4.70) */
> +#define PCIE_CORE_VERSION 0x8F8
> +#define PCIE_CORE_VERSION_480A 0x3438302a
This should add a use of these symbols at the same time. There's no
point if adding things that aren't used.
> /* Synopsys specific PCIE configuration registers */
> #define PCIE_PORT_LINK_CONTROL 0x710
> #define PORT_LINK_MODE_MASK (0x3f << 16)
> --
> 1.8.1.5
>
prev parent reply other threads:[~2016-07-25 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 13:29 [PATCH v2 0/2] pcie-designware: add iATU unroll feature Joao Pinto
2016-07-22 13:29 ` [PATCH v2 1/2] pcie-designware: add iATU Unroll feature Joao Pinto
2016-07-25 20:44 ` Bjorn Helgaas
2016-08-02 10:27 ` Joao Pinto
2016-08-02 12:53 ` Bjorn Helgaas
2016-08-02 14:27 ` Joao Pinto
2016-07-22 13:29 ` [PATCH v2 2/2] pcie-designware: add core version Joao Pinto
2016-07-25 20:16 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725201613.GA15939@localhost \
--to=helgaas@kernel.org \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=MiguelFalcao.Sousa@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.