From: Brian Norris <briannorris@chromium.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Olof Johansson <olof@lixom.net>,
Brian Norris <computersforpeace@gmail.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
Date: Mon, 25 Jul 2016 13:48:25 -0700 [thread overview]
Message-ID: <20160725204825.GA144142@google.com> (raw)
In-Reply-To: <20160725204313.GA1698@katana>
On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote:
> On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote:
> > cros_ec_cmd_xfer returns success status if the command transport
> > completes successfully, but the execution result is incorrectly ignored.
> > In many cases, the execution result is assumed to be successful, leading
> > to ignored errors and operating on uninitialized data.
> >
> > We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
> > problems. Let's use it.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> I agree with Dmitry about Thierry pushing the patch. So:
>
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
Fine with me, as long as Thierry is up for it.
BTW, I think the dependency is on target for v4.8-rc1, so if Thierry
misses this, then you should be able to apply this yourself after the
merge window.
Regards,
Brian
next prev parent reply other threads:[~2016-07-25 20:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 18:14 [PATCH 0/2] cros_ec: utilize cros_ec_cmd_xfer_status() Brian Norris
2016-07-25 18:14 ` [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer() Brian Norris
2016-07-25 18:31 ` kbuild test robot
2016-07-25 18:31 ` kbuild test robot
2016-07-25 19:45 ` Javier Martinez Canillas
2016-07-25 20:43 ` Wolfram Sang
2016-07-25 20:48 ` Brian Norris [this message]
2016-07-26 9:14 ` Thierry Reding
2016-07-26 18:38 ` Brian Norris
2016-07-28 14:15 ` Thierry Reding
2016-07-25 18:14 ` [PATCH 2/2] Input: cros_ec_keyb - " Brian Norris
2016-07-25 18:28 ` Dmitry Torokhov
2016-07-25 18:38 ` kbuild test robot
2016-07-25 18:38 ` kbuild test robot
2016-07-25 19:46 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725204825.GA144142@google.com \
--to=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
--cc=shawnn@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.