All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] config.mak.uname: correct perl path on FreeBSD
Date: Tue, 26 Jul 2016 06:18:54 +0000	[thread overview]
Message-ID: <20160726061854.GA13334@starla> (raw)
In-Reply-To: <xmqqoa5l4fh0.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:
> Eric Wong <e@80x24.org> writes:
> > Junio C Hamano <gitster@pobox.com> wrote:
> >> Duy Nguyen <pclouds@gmail.com> writes:
> >> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
> >> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> > about the problem sooner.
> >
> >> >>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> >> >>> ---
> >> >>>  Tested with fbsd 10.3, kvm image. But I suppose it's the same as real
> >> >>>  fbsd.
> >> >>
> >> >> Thanks; and we know that older (but not too old that we no longer care about)
> >> >> FreeBSD all have /usr/local/bin/perl?
> >> >
> >> > I'm no fbsd expert but from the first sentence in [1] "Perl has been
> >> > removed from base more than ten years ago..." I would assume it meant
> >> > "... removed from base, _to_ ports system" which means /usr/local for
> >> > all package installation (for ten years for perl). So I think we are
> >> > good.
> >> 
> >> I guess we didn't follow through
> >> 
> >>     http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/
> >> 
> >> and allowed the thread to drift into a tangent?
> >
> > +Cc Dscho
> >
> > I've been meaning to followup on that, but had connectivity
> > problems to my VM last week.  I still prefer we use numeric
> > comparisons for version numbers since numbers are... numeric.
> > IOW, I prefer we go with my original patch.
> 
> I tend to agree with you if we have to do "systems older than this
> should use /usr/bin, others should use /usr/local/bin", but this
> different incarnation of the same topic seems to claim that older
> ones had /usr/local/bin forever anyway, and that was what made the
> patch interesting.

I dug around the freebsd history (git://github.com/freebsd/freebsd.git)
(~1.5G) and the 3.x and 4.x releases with perl in base still contained
many references to /usr/local/bin/perl

It also seems FreeBSD 2.x releases were also perl-less in base;
so yes, I'm alright with Duy's patch :)

  reply	other threads:[~2016-07-26  6:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 16:21 [PATCH] config.mak.uname: correct perl path on FreeBSD Nguyễn Thái Ngọc Duy
2016-07-25 16:56 ` Junio C Hamano
2016-07-25 17:27   ` Duy Nguyen
2016-07-25 18:11     ` Junio C Hamano
2016-07-25 20:33       ` Eric Wong
2016-07-25 20:42         ` Junio C Hamano
2016-07-26  6:18           ` Eric Wong [this message]
2016-07-26  6:47             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726061854.GA13334@starla \
    --to=e@80x24.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.