From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/6] pkg-download: Allow packages to pass generic options to download methods
Date: Tue, 26 Jul 2016 18:28:59 +0200 [thread overview]
Message-ID: <20160726162859.GC5925@free.fr> (raw)
In-Reply-To: <1469521290-20446-3-git-send-email-romain.perier@free-electrons.com>
Romain, All,
On 2016-07-26 10:21 +0200, Romain Perier spake thusly:
> Introduce a new package variable $(PKG)_DL_OPTS. When this variable
> is defined, its value is passed to the downloader as options to
> the underlying command. Packages can now retrieve archives from server
> expecting logins and passwords, use referer url, proxy or specific
> options for cloning a repository.
>
> Signed-off-by: Romain Perier <romain.perier@free-electrons.com>
You forgot to add my Reviewed-by tag from the previous review:
http://lists.busybox.net/pipermail/buildroot/2016-July/167658.html
Here it is again, just for you! ;-)
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
>
> Changes in v2:
> - Replaced $(PKG)_DL_REFERER by $(PKG)_DL_OPTS
> - Add support for this options to all downloaders
>
> package/pkg-download.mk | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index a0f694d..00fbe6c 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -80,7 +80,8 @@ define DOWNLOAD_GIT
> -- \
> $($(PKG)_SITE) \
> $($(PKG)_DL_VERSION) \
> - $($(PKG)_BASE_NAME)
> + $($(PKG)_BASE_NAME) \
> + $($(PKG)_DL_OPTS)
> endef
>
> # TODO: improve to check that the given PKG_DL_VERSION exists on the remote
> @@ -96,7 +97,8 @@ define DOWNLOAD_BZR
> -- \
> $($(PKG)_SITE) \
> $($(PKG)_DL_VERSION) \
> - $($(PKG)_BASE_NAME)
> + $($(PKG)_BASE_NAME) \
> + $($(PKG)_DL_OPTS)
> endef
>
> define SOURCE_CHECK_BZR
> @@ -111,7 +113,8 @@ define DOWNLOAD_CVS
> $(call stripurischeme,$(call qstrip,$($(PKG)_SITE))) \
> $($(PKG)_DL_VERSION) \
> $($(PKG)_RAWNAME) \
> - $($(PKG)_BASE_NAME)
> + $($(PKG)_BASE_NAME) \
> + $($(PKG)_DL_OPTS)
> endef
>
> # Not all CVS servers support ls/rls, use login to see if we can connect
> @@ -126,7 +129,8 @@ define DOWNLOAD_SVN
> -- \
> $($(PKG)_SITE) \
> $($(PKG)_DL_VERSION) \
> - $($(PKG)_BASE_NAME)
> + $($(PKG)_BASE_NAME) \
> + $($(PKG)_DL_OPTS)
> endef
>
> define SOURCE_CHECK_SVN
> @@ -142,7 +146,8 @@ define DOWNLOAD_SCP
> -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
> $(QUIET) \
> -- \
> - '$(call stripurischeme,$(call qstrip,$(1)))'
> + '$(call stripurischeme,$(call qstrip,$(1)))' \
> + $($(PKG)_DL_OPTS)
> endef
>
> define SOURCE_CHECK_SCP
> @@ -156,7 +161,8 @@ define DOWNLOAD_HG
> -- \
> $($(PKG)_SITE) \
> $($(PKG)_DL_VERSION) \
> - $($(PKG)_BASE_NAME)
> + $($(PKG)_BASE_NAME) \
> + $($(PKG)_DL_OPTS)
> endef
>
> # TODO: improve to check that the given PKG_DL_VERSION exists on the remote
> @@ -171,7 +177,8 @@ define DOWNLOAD_WGET
> -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
> $(QUIET) \
> -- \
> - '$(call qstrip,$(1))'
> + '$(call qstrip,$(1))' \
> + $($(PKG)_DL_OPTS)
> endef
>
> define SOURCE_CHECK_WGET
> @@ -184,7 +191,8 @@ define DOWNLOAD_LOCALFILES
> -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
> $(QUIET) \
> -- \
> - $(call stripurischeme,$(call qstrip,$(1)))
> + $(call stripurischeme,$(call qstrip,$(1))) \
> + $($(PKG)_DL_OPTS)
> endef
>
> define SOURCE_CHECK_LOCALFILES
> --
> 2.8.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-07-26 16:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 8:21 [Buildroot] [PATCH v3 0/6] Add support for AMD Catalyst graphics driver Romain Perier
2016-07-26 8:21 ` [Buildroot] [PATCH v3 1/6] support/download: Add support to pass options directly to downloaders Romain Perier
2016-07-26 16:26 ` Yann E. MORIN
2016-07-26 8:21 ` [Buildroot] [PATCH v3 2/6] pkg-download: Allow packages to pass generic options to download methods Romain Perier
2016-07-26 16:28 ` Yann E. MORIN [this message]
2016-07-26 8:21 ` [Buildroot] [PATCH v3 3/6] docs/manual: Document the variable $(PKG)_DL_OPTS Romain Perier
2016-07-26 16:29 ` Yann E. MORIN
2016-07-26 8:21 ` [Buildroot] [PATCH v3 4/6] package/xserver_xorg-server: add version 1.17.4 Romain Perier
2016-07-26 8:21 ` [Buildroot] [PATCH v3 5/6] qt: Add option for enabling the accessibility support Romain Perier
2016-07-26 8:21 ` [Buildroot] [PATCH v3 6/6] package/amd-catalyst-driver: Add AMD proprietary graphic stack support Romain Perier
2016-07-26 20:39 ` Yann E. MORIN
2016-07-27 7:35 ` Thomas Petazzoni
2016-07-28 16:12 ` Yann E. MORIN
2016-08-05 10:28 ` Thomas Petazzoni
2016-07-27 8:15 ` Romain Perier
2016-07-27 16:24 ` Yann E. MORIN
2016-07-27 19:36 ` Thomas Petazzoni
2016-07-27 22:08 ` Yann E. MORIN
2016-07-26 9:28 ` [Buildroot] [PATCH v3 0/6] Add support for AMD Catalyst graphics driver Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726162859.GC5925@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.