From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH net-next v2 2/3] virtio: cleanup sizeof usage Date: Tue, 26 Jul 2016 09:37:14 -0700 Message-ID: <20160726163746.075661641@networkplumber.org> References: <20160726163712.721213063@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Cc: netdev@vger.kernel.org, Stephen Hemminger To: "Michael S. Tsirkin" Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:33868 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757211AbcGZQhb (ORCPT ); Tue, 26 Jul 2016 12:37:31 -0400 Received: by mail-pa0-f41.google.com with SMTP id fi15so1333840pac.1 for ; Tue, 26 Jul 2016 09:37:31 -0700 (PDT) Content-Disposition: inline; filename=virtio-sizeof.patch Sender: netdev-owner@vger.kernel.org List-ID: Although sizeof is an operator in C. Preferred usage is to use it as a function. Signed-off-by: Stephen Hemminger --- a/drivers/net/virtio_net.c 2016-07-26 09:13:16.173384238 -0700 +++ b/drivers/net/virtio_net.c 2016-07-26 09:13:16.169384220 -0700 @@ -272,7 +272,7 @@ static struct sk_buff *page_to_skb(struc hdr_len = vi->hdr_len; if (vi->mergeable_rx_bufs) - hdr_padded_len = sizeof *hdr; + hdr_padded_len = sizeof(struct virtio_net_hdr_mrg_rxbuf); else hdr_padded_len = sizeof(struct padded_vnet_hdr);