From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757405AbcGZRBd (ORCPT ); Tue, 26 Jul 2016 13:01:33 -0400 Received: from mail-yw0-f178.google.com ([209.85.161.178]:35752 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbcGZRBb (ORCPT ); Tue, 26 Jul 2016 13:01:31 -0400 Date: Tue, 26 Jul 2016 13:01:23 -0400 From: Tejun Heo To: Bhaktipriya Shridhar Cc: Miguel Ojeda Sandonis , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cfag12864b: Remove deprecated create_singlethread_workqueue Message-ID: <20160726170123.GW19588@mtj.duckdns.org> References: <20160726165300.GA9430@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160726165300.GA9430@Karyakshetra> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 10:23:00PM +0530, Bhaktipriya Shridhar wrote: > @@ -257,7 +256,6 @@ void cfag12864b_disable(void) > if (cfag12864b_updating) { > cfag12864b_updating = 0; > cancel_delayed_work(&cfag12864b_work); > - flush_workqueue(cfag12864b_workqueue); It should be converted to cancel_delayed_work_sync(); otherwise, nothing guarantees that the work item is finished. Thanks. -- tejun