All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@mellanox.com>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Matan Barak <matanb@mellanox.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue
Date: Tue, 26 Jul 2016 21:11:07 +0300	[thread overview]
Message-ID: <20160726181107.GB4628@leon.nu> (raw)
In-Reply-To: <20160726170824.GA10721@Karyakshetra>

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Tue, Jul 26, 2016 at 10:38:24PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue health->wq was used as per device private health thread.
> This was done to perform delayed work.
> 
> The workqueue has a single workitem(&health->work) and
> hence doesn't require ordering. It is involved in handling the health of
> the device and is not being used on a memory reclaim path.
> Hence, the singlethreaded workqueue has been replaced with the use of
> system_wq.
> 
> Work item has been flushed in mlx5_health_cleanup() to ensure that
> there are no pending tasks while disconnecting the driver.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  Changes in v2:
> 	-Updated commit description as per the feedback received.
> 
>  drivers/net/ethernet/mellanox/mlx5/core/health.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-07-26 18:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-16  7:59 [PATCH] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-07-16  7:59 ` Bhaktipriya Shridhar
2016-07-17  5:13 ` Leon Romanovsky
2016-07-17  5:13   ` Leon Romanovsky
2016-07-17 13:35   ` Bhaktipriya Shridhar
     [not found]   ` <20160717051327.GA20674-2ukJVAZIZ/Y@public.gmane.org>
2016-07-26 17:08     ` [PATCH v2] " Bhaktipriya Shridhar
2016-07-26 17:08       ` Bhaktipriya Shridhar
2016-07-26 18:11       ` Leon Romanovsky [this message]
2016-07-26 22:19       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726181107.GB4628@leon.nu \
    --to=leonro@mellanox.com \
    --cc=bhaktipriya96@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matanb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.