From: Max Filippov <jcmvbkbc@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"
Date: Tue, 26 Jul 2016 21:50:30 +0300 [thread overview]
Message-ID: <20160726185030.GA1787@octofox.metropolis> (raw)
In-Reply-To: <20160726180132.12764-1-robh@kernel.org>
On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote:
> This partially reverts commit 69d99e6c0d62 keeping only the main
> purpose of the original commit which is the removal of
> of_platform_populate() call. The moving of of_clk_init() caused changes
> in the initialization order breaking booting.
>
> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> This is on top of Guenter's build fix. Please test and I'll apply. I
Tested-by: Max Filippov <jcmvbkbc@gmail.com>
> tried briefly running under QEMU, but didn't have success. If anyone has
> up to date instructions that would be helpful as using these[1] didn't
> seem to work.
I think they're up to date. Another thing that need to be done right is
the toolchain: it must match the configured CPU core. Please refer to
http://wiki.linux-xtensa.org/index.php/Toolchain_Overlay_File
for more details.
>
> [1] http://wiki.linux-xtensa.org/index.php/Xtensa_on_QEMU
>
> arch/xtensa/kernel/setup.c | 9 +++++++++
> arch/xtensa/kernel/time.c | 2 --
> 2 files changed, 9 insertions(+), 2 deletions(-)
--
Thanks.
-- Max
next prev parent reply other threads:[~2016-07-26 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 18:01 [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table" Rob Herring
2016-07-26 18:50 ` Max Filippov [this message]
2016-07-26 19:13 ` Rob Herring
2016-07-26 19:49 ` Max Filippov
2016-07-27 6:56 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726185030.GA1787@octofox.metropolis \
--to=jcmvbkbc@gmail.com \
--cc=chris@zankel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.