From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSJE5-0004RI-Tz for qemu-devel@nongnu.org; Wed, 27 Jul 2016 03:26:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSJE1-0003Um-7r for qemu-devel@nongnu.org; Wed, 27 Jul 2016 03:25:56 -0400 Date: Wed, 27 Jul 2016 15:25:43 +0800 From: Fam Zheng Message-ID: <20160727072543.GF23258@ad.usersys.redhat.com> References: <1469129688-22848-1-git-send-email-eblake@redhat.com> <1469129688-22848-5-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469129688-22848-5-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/4] block: Cater to iscsi with non-power-of-2 discard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, pl@kamp.de, pbonzini@redhat.com, Stefan Hajnoczi , Kevin Wolf , Max Reitz On Thu, 07/21 13:34, Eric Blake wrote: > + max_write_zeroes = max_write_zeroes / alignment * alignment; Not using QEMU_ALIGN_DOWN despite patch 3?