All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Dave Hansen <dave.hansen@intel.com>,
	Yu-Cheng Yu <yu-cheng.yu@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Ravi Shankar <ravi.v.shankar@intel.com>
Subject: Re: [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in XSAVES compacted-format buffer
Date: Wed, 27 Jul 2016 11:00:28 +0200	[thread overview]
Message-ID: <20160727090028.GA30204@gmail.com> (raw)
In-Reply-To: <1469480888-14363-1-git-send-email-sai.praneeth.prakhya@intel.com>


* Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> wrote:

> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
> 
> Currently, XSAVES compacted-format buffer will always contain space for
> all enabled states. If XSAVES compacted-format buffer is in use and
> an xstate component (E.g: PKRU xstate) is not present in the buffer
> (i.e. xcomp_bv does not have xfeature (E.g: XFEATURE_MASK_PKRU) bit
> set), then fpu__xfeature_set_state() returns error.

Please fix the changelog to conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

Thanks,

        Ingo

      reply	other threads:[~2016-07-27  9:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 21:08 [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in XSAVES compacted-format buffer Sai Praneeth Prakhya
2016-07-27  9:00 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160727090028.GA30204@gmail.com \
    --to=mingo@kernel.org \
    --cc=dave.hansen@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=sai.praneeth.prakhya@intel.com \
    --cc=x86@kernel.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.