All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] nettle: disable assembly optimizations for ARMv7M
Date: Wed, 27 Jul 2016 10:13:48 +0200	[thread overview]
Message-ID: <20160727101348.6861fa2e@free-electrons.com> (raw)
In-Reply-To: <87zip3y0ca.fsf@dell.be.48ers.dk>

Hello,

On Wed, 27 Jul 2016 10:03:17 +0200, Peter Korsgaard wrote:

>  > I don't think this is equivalent. Indeed, ARMv6 doesn't have Thumb2 (at
>  > least from Buildroot point of view), while the assembly code in Nettle
>  > is OK for ARMv6.  
> 
> True, but then the commit message doesn't make any sense as it said it
> required thumb2 and classic in structions.

That's not what the commit message said. The commit message said:

"""
    nettle: disable assembly optimizations for ARMv7M
    
    It's thumb2-only and it requires ARM instructions.
"""

So it did not say at all that nettle requires Thumb-2 *and* classic. It
said that ARMv7M provides only thumb2, and that nettle requires ARM
instructions.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-27  8:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25  0:15 [Buildroot] [PATCH] nettle: disable assembly optimizations for ARMv7M Gustavo Zacarias
2016-07-25 20:48 ` Thomas Petazzoni
2016-07-26 21:18   ` Peter Korsgaard
2016-07-27  7:15     ` Thomas Petazzoni
2016-07-27  8:03       ` Peter Korsgaard
2016-07-27  8:13         ` Thomas Petazzoni [this message]
2016-07-27  9:23           ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160727101348.6861fa2e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.