From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one
Date: Wed, 27 Jul 2016 15:34:10 +0300 [thread overview]
Message-ID: <20160727123410.GI4628@leon.nu> (raw)
In-Reply-To: <20160727114238.GB3549-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
On Wed, Jul 27, 2016 at 02:42:39PM +0300, Yuval Shaia wrote:
> On Wed, Jul 27, 2016 at 02:23:29PM +0300, Leon Romanovsky wrote:
> > On Wed, Jul 27, 2016 at 01:26:41PM +0300, Yuval Shaia wrote:
> > > On Wed, Jul 27, 2016 at 11:58:00AM +0300, Leon Romanovsky wrote:
> > > > On Wed, Jul 27, 2016 at 01:24:51AM -0700, Yuval Shaia wrote:
> > > > > Please review the following two patches.
> > > > > First patch makes int-return function to a void one as it anyway returns 0.
> > > > > Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
> > > > > to EAGAIN.
> > > >
> > > > Thanks Yuval for taking time to do it.
> > > > After your's IPoIB patches, we prepared patch similar to these and
> > > > planned to send it after merge window will close.
> > >
> > > Great new!
> > > So, will you also take care of making the function use_tunnel_data void?
> >
> > No problem, I'll resubmit your use_tunnel_data patch.
> > Thanks
>
> With the surrounding {} please :)
> I can send v1 if needed.
There is no need, I already added correct version to our verification
system.
Thanks
>
> >
> > >
> > > >
> > > > >
> > > > > [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
> > > > > [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
> > > > > --
> > > > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >
> > >
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-27 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 8:24 IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one Yuval Shaia
[not found] ` <1469607893-10657-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-07-27 8:24 ` [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void Yuval Shaia
[not found] ` <1469607893-10657-2-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-07-27 8:52 ` kbuild test robot
2016-07-27 11:39 ` Leon Romanovsky
2016-07-27 12:53 ` kbuild test robot
2016-07-27 8:24 ` [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one Yuval Shaia
2016-07-27 8:58 ` IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one Leon Romanovsky
[not found] ` <20160727085800.GF4628-2ukJVAZIZ/Y@public.gmane.org>
2016-07-27 10:26 ` Yuval Shaia
[not found] ` <20160727102640.GA3549-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-07-27 11:23 ` Leon Romanovsky
[not found] ` <20160727112329.GG4628-2ukJVAZIZ/Y@public.gmane.org>
2016-07-27 11:42 ` Yuval Shaia
[not found] ` <20160727114238.GB3549-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-07-27 12:34 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727123410.GI4628@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.