From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
anton@samba.org, Song Shan Gong <gongss@linux.vnet.ibm.com>,
jolsa@kernel.org, dsahern@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/perf: fix 'start' address of module's map
Date: Wed, 27 Jul 2016 10:05:53 -0300 [thread overview]
Message-ID: <20160727130553.GC5200@kernel.org> (raw)
In-Reply-To: <87shuvv3g5.fsf@concordia.ellerman.id.au>
Em Wed, Jul 27, 2016 at 07:24:26PM +1000, Michael Ellerman escreveu:
> Arnaldo Carvalho de Melo <acme@kernel.org> writes:
> > Em Tue, Jul 26, 2016 at 10:14:18PM +0200, Christian Borntraeger escreveu:
> >> On 07/26/2016 09:50 PM, Arnaldo Carvalho de Melo wrote:
> >> > So I could as well use what is in /sys/module/tun/sections/.text instead
> >> > of reading it from /proc/modules and, in s390, reading it from
> >> > /sys/module/tun/sections/.text.
> >> > Do you see any problem with using this approach for _all_ arches?
> >> I think it should work well for _all_ arches but it will probably be
> >> hard to test this without help.
> > Well, we could check for the cases we don't know, i.e. read from both
> > and warn about cases where it is different, except for s390 where we now
> > which is the right one to pick.
> >> I wouldn't be surprised if other architectures than s390 actually have
> >> the same issue, so doing this for everybody might atually fix this somewhere
> >> else.
> > Would be nice to get info from other arch people, Michael, how this goes
> > on ppc?
> It doesn't look like this is a problem on powerpc - at least I haven't
> heard of it.
> Looking at a system I have here, for all modules (26) the value in
> /proc/modules matches the .text section in /sys.
> So I think using /sys should be fine for us.
Thanks for checking.
- Arnaldo
next prev parent reply other threads:[~2016-07-27 13:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 3:10 [RFC PATCH V4]s390/perf:fix 'start' address of module's map Song Shan Gong
2016-07-21 3:10 ` [PATCH] s390/perf: fix " Song Shan Gong
2016-07-22 2:47 ` Songshan Gong
2016-07-26 6:54 ` Jiri Olsa
2016-07-26 19:50 ` Arnaldo Carvalho de Melo
2016-07-26 20:14 ` Christian Borntraeger
2016-07-26 20:29 ` Arnaldo Carvalho de Melo
2016-07-27 9:24 ` Michael Ellerman
2016-07-27 13:05 ` Arnaldo Carvalho de Melo [this message]
2016-07-27 10:10 ` Songshan Gong
2016-07-27 10:49 ` Songshan Gong
2016-07-27 13:08 ` Arnaldo Carvalho de Melo
2016-07-28 2:01 ` Songshan Gong
2016-07-27 10:05 ` Songshan Gong
2016-07-27 10:41 ` [tip:perf/urgent] perf s390: Fix " tip-bot for Song Shan Gong
-- strict thread matches above, loose matches on Subject: below --
2016-07-19 11:31 [RFC PATCH V3]s390/perf:fix " Song Shan Gong
2016-07-19 11:31 ` [PATCH] s390/perf: fix " Song Shan Gong
2016-07-20 11:51 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727130553.GC5200@kernel.org \
--to=acme@kernel.org \
--cc=anton@samba.org \
--cc=borntraeger@de.ibm.com \
--cc=dsahern@gmail.com \
--cc=gongss@linux.vnet.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.