From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC/PATCHSET 0/7] virtio: Implement virtio pstore device (v2) Date: Thu, 28 Jul 2016 01:18:42 +0300 Message-ID: <20160728011602-mutt-send-email-mst@kernel.org> References: <1469632111-23260-1-git-send-email-namhyung@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1469632111-23260-1-git-send-email-namhyung@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Namhyung Kim Cc: Tony Luck , Kees Cook , kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , LKML , Anton Vorontsov , Will Deacon , qemu-devel@nongnu.org, Steven Rostedt , virtualization@lists.linux-foundation.org, Minchan Kim , Anthony Liguori , Colin Cross , Paolo Bonzini , Ingo Molnar List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCBKdWwgMjgsIDIwMTYgYXQgMTI6MDg6MjRBTSArMDkwMCwgTmFtaHl1bmcgS2ltIHdy b3RlOgo+IEhlbGxvLAo+IAo+IFRoaXMgaXMgdjIgb2YgdGhlIHZpcnRpby1wc3RvcmUgd29yay4g IEluIHRoaXMgcGF0Y2hzZXQgSSBhZGRyZXNzZWQKPiBtb3N0IG9mIGZlZWRiYWNrcyBmcm9tIHBy ZXZpb3VzIHZlcnNpb24uICBMaW1pdGluZyBkaXNrIHNpemUgaXMgbm90Cj4gaW1wbGVtZW50ZWQg eWV0LgoKRm9yIHNvbWUgcmVhc29uLCBvbmx5IHBhcnRzIG9mIHRoZSBwYXRjaHNldCB3ZXJlIHJl Y2VpdmVkLgpQbHMgcG9zdCBhbGwgcGF0Y2hlcyB0byBhbGwgbGlzdHMuCgpJZiB5b3UgYXJlIGNo YW5naW5nIHRoZSB2aXJ0aW8gaW50ZXJmYWNlIHdpdGggaG9zdCwKbGlrZSBhIG5ldyBkZXZpY2Us IHRoZXkgeW91IG11c3QgY29weSB0aGUgdmlydGlvIFRDCnNvIG1ha2Ugc3VyZSB0aGVyZSBhcmUg bm8gb2JqZWN0aW9ucyBmcm9tIHRoZXJlLgoKaHR0cHM6Ly93d3cub2FzaXMtb3Blbi5vcmcvY29t bWl0dGVlcy90Y19ob21lLnBocD93Z19hYmJyZXY9dmlydGlvI2ZlZWRiYWNrCgoKCj4gICogY2hh bmdlcyBpbiB2MikKPiAgIC0gdXBkYXRlIFZJUlRJT19JRF9QU1RPUkUgdG8gMjIgIChDb3JuZWxp YSwgU3RlZmFuKQo+ICAgLSBtYWtlIGJ1ZmZlciBzaXplIGNvbmZpZ3VyYWJsZSAgKENvcm5lbGlh KQo+ICAgLSBzdXBwb3J0IFBTVE9SRV9UWVBFX0NPTlNPTEUgIChLZWVzKQo+ICAgLSB1c2Ugc2Vw YXJhdGUgdmlydHF1ZXVlcyBmb3IgcmVhZCBhbmQgd3JpdGUKPiAgIC0gc3VwcG9ydCBjb25jdXJy ZW50IGFzeW5jIHdyaXRlCj4gICAtIG1hbmFnZSBwc3RvcmUgKGZpbGUpIGlkIGluIGRldmljZSBz aWRlCj4gICAtIGZpeCB2YXJpb3VzIG1pc3Rha2VzIGluIHFlbXUgZGV2aWNlICAoU3RlZmFuKQo+ IAo+IEl0IHN0YXJ0ZWQgZnJvbSB0aGUgZmFjdCB0aGF0IGR1bXBpbmcgZnRyYWNlIGJ1ZmZlciBh dCBrZXJuZWwKPiBvb3BzL3BhbmljIHRha2VzIHRvbyBtdWNoIHRpbWUuICBBbHRob3VnaCB0aGVy ZSdzIGEgd2F5IHRvIHJlZHVjZSB0aGUKPiBzaXplIG9mIHRoZSBvcmlnaW5hbCBkYXRhLCBzb21l dGltZXMgSSB3YW50IHRvIGhhdmUgdGhlIGluZm9ybWF0aW9uIGFzCj4gbWFueSBhcyBwb3NzaWJs ZS4gIE1heWJlIGtleGVjL2tkdW1wIGNhbiBzb2x2ZSB0aGlzIHByb2JsZW0gYnV0IGl0Cj4gY29u c3VtZXMgc29tZSBwb3J0aW9uIG9mIGd1ZXN0IG1lbW9yeSBzbyBJJ2QgbGlrZSB0byBhdm9pZCBp dC4gIEFuZCBJCj4ga25vdyB0aGUgcWVtdSArIGNyYXNodG9vbCBjYW4gZHVtcCBhbmQgYW5hbHl6 ZSB0aGUgd2hvbGUgZ3Vlc3QgbWVtb3J5Cj4gaW5jbHVkaW5nIHRoZSBmdHJhY2UgYnVmZmVyIHdp dGhvdXQgd2FzdGluZyBndWVzdCBtZW1vcnksIGJ1dCBpdCBhZGRzCj4gb25lIG1vcmUgbGF5ZXIg YW5kIGhhcyBzb21lIGxpbWl0YXRpb24gYXMgYW4gb3V0LW9mLXRyZWUgdG9vbCBsaWtlIG5vdAo+ IGJlaW5nIGluIHN5bmMgd2l0aCB0aGUga2VybmVsIGNoYW5nZXMuCj4gCj4gU28gSSB0aGluayBp dCdkIGJlIGdyZWF0IHVzaW5nIHRoZSBwc3RvcmUgaW50ZXJmYWNlIHRvIGR1bXAgZ3Vlc3QKPiBr ZXJuZWwgZGF0YSBvbiB0aGUgaG9zdC4gIE9uZSBjYW4gcmVhZCB0aGUgZGF0YSBvbiB0aGUgaG9z dCBkaXJlY3RseQo+IG9yIG9uIHRoZSBndWVzdCAoYXQgdGhlIG5leHQgYm9vdCkgdXNpbmcgcHN0 b3JlIGZpbGVzeXN0ZW0gYXMgdXN1YWwuCj4gV2hpbGUgdGhpcyBwYXRjaHNldCBvbmx5IGltcGxl bWVudHMgZHVtcGluZyBrZXJuZWwgbG9nIGJ1ZmZlciwgaXQgY2FuCj4gYmUgZXh0ZW5kZWQgdG8g aGF2ZSBmdHJhY2UgYnVmZmVyIGFuZCBwcm9iYWJseSBzb21lIG1vcmUuLgo+IAo+IFRoZSBwYXRj aCAwMDAxLTAwMDMgYXJlIHByZXBhcmF0aW9uIGZvciBwc3RvcmUgdG8gc3VwcG9ydCB2aXJ0aW8K PiBkZXZpY2Ugd2hpY2ggcmVxdWlyZXMgYXN5bmMgd3JpdGUuICBUaGUgcGF0Y2ggMDAwNCBpbXBs ZW1lbnRzIHZpcnRpbwo+IHBzdG9yZSBkcml2ZXIuICBJdCBoYXMgdHdvIHZpcnQgcXVldWUgZm9y IChzeW5jKSByZWFkIGFuZCAoYXN5bmMpCj4gd3JpdGUsIHBzdG9yZSBidWZmZXIgYW5kIGlvIHJl cXVlc3QgYW5kIHJlc3BvbnNlIHN0cnVjdHVyZS4gIFRoZQo+IHZpcnRpb19wc3RvcmVfcmVxIHN0 cnVjdCBpcyB0byBnaXZlIGluZm9ybWF0aW9uIGFib3V0IHRoZSBjdXJyZW50Cj4gcHN0b3JlIG9w ZXJhdGlvbi4gIFRoZSByZXN1bHQgd2lsbCBiZSB3cml0dGVuIHRvIHRoZSB2aXJ0aW9fcHN0b3Jl X3Jlcwo+IHN0cnVjdC4gIEZvciByZWFkIG9wZXJhdGlvbiBpdCBhbHNvIHVzZXMgdmlydGlvX3Bz dG9yZV9maWxlaW5mbyBzdHJ1Y3QuCj4gCj4gVGhlIHBhdGNoIDAwMDUgYWRkcyBzdXBwb3J0IGZv ciBQU1RPUkVfVFlQRV9DT05TT0xFIHdoaWNoIHdhcwo+IHJlcXVlc3RlZCBieSBLZWVzLiAgVGhl IGNvbnNvbGUgZGF0YSBpcyBhcHBlbmRlZCB0byBhIHNpbmdsZSBmaWxlIGZvcgo+IG5vdy4KPiAK PiBUaGUgcGF0Y2ggMDAwNiBhbmQgMDAwNyBpbXBsZW1lbnQgdmlydGlvLXBzdG9yZSBsZWdhY3kg UENJIGRldmljZSBvbgo+IHFlbXUta3ZtIGFuZCBrdm10b29sIHJlc3BlY3RpdmVseS4gIEkgcmVm ZXJlbmNlZCB2aXJ0aW8tYmFsb29uIGFuZAo+IHZpcnRpby1ybmcgaW1wbGVtZW50YXRpb25zIGFu ZCBJIGRvbid0IGtub3cgd2hldGhlciBrdm10b29sIHN1cHBvcnRzCj4gbW9kZXJuIHZpcnRpbyAx LjArIHNwZWMuICBPdGhlciB0cmFuc3BvcnRzIG1pZ2h0IGJlIHN1cHBvcnRlZCBsYXRlci4KPiAK PiBGb3IgZXhhbXBsZSwgdXNpbmcgdmlydGlvLXBzdG9yZSBvbiBxZW11IGxvb2tzIGxpa2UgYmVs b3c6Cj4gCj4gICAkIHFlbXUtc3lzdGVtLXg4Nl82NCAtZW5hYmxlLWt2bSAtZGV2aWNlIHZpcnRp by1wc3RvcmUsZGlyZWN0b3J5PXh4eAo+IAo+IFdoZW4gZ3Vlc3Qga2VybmVsIGdldHMgcGFuaWMg dGhlIGxvZyBtZXNzYWdlcyB3aWxsIGJlIHNhdmVkIHVuZGVyIHRoZQo+IHh4eCBkaXJlY3Rvcnku Cj4gCj4gICAkIGxzIHh4eAo+ICAgZG1lc2ctMS5lbmMueiAgZG1lc2ctMi5lbmMuego+IAo+IEFz IHlvdSBjYW4gc2VlIHRoZSBwc3RvcmUgc3Vic3lzdGVtIGNvbXByZXNzZXMgdGhlIGxvZyBkYXRh IHVzaW5nIHpsaWIKPiAobm93IHN1cHBvcnRzIGx6byBhbmQgbHo0IHRvbykuICBUaGUgZGF0YSBj YW4gYmUgZXh0cmFjdGVkIHdpdGggdGhlCj4gZm9sbG93aW5nIGNvbW1hbmQ6Cj4gCj4gICAkIGNh dCB4eHgvZG1lc2ctMS5lbmMueiB8IFwKPiAgID4gcHl0aG9uIC1jICdpbXBvcnQgc3lzLCB6bGli OyBwcmludCh6bGliLmRlY29tcHJlc3Moc3lzLnN0ZGluLnJlYWQoKSkpJwo+ICAgT29wcyMxIFBh cnQxCj4gICA8NT5bICAgIDAuMDAwMDAwXSBMaW51eCB2ZXJzaW9uIDQuNi4wa3ZtKyAobmFtaHl1 bmdAZGFuamFlKSAoZ2NjIHZlcnNpb24gNS4zLjAgKEdDQykgKSAjMTQ1IFNNUCBNb24gSnVsIDE4 IDEwOjIyOjQ1IEtTVCAyMDE2Cj4gICA8Nj5bICAgIDAuMDAwMDAwXSBDb21tYW5kIGxpbmU6IHJv b3Q9L2Rldi92ZGEgY29uc29sZT10dHlTMAo+ICAgPDY+WyAgICAwLjAwMDAwMF0geDg2L2ZwdTog TGVnYWN5IHg4NyBGUFUgZGV0ZWN0ZWQuCj4gICA8Nj5bICAgIDAuMDAwMDAwXSB4ODYvZnB1OiBV c2luZyAnZWFnZXInIEZQVSBjb250ZXh0IHN3aXRjaGVzLgo+ICAgPDY+WyAgICAwLjAwMDAwMF0g ZTgyMDogQklPUy1wcm92aWRlZCBwaHlzaWNhbCBSQU0gbWFwOgo+ICAgPDY+WyAgICAwLjAwMDAw MF0gQklPUy1lODIwOiBbbWVtIDB4MDAwMDAwMDAwMDAwMDAwMC0weDAwMDAwMDAwMDAwOWZiZmZd IHVzYWJsZQo+ICAgPDY+WyAgICAwLjAwMDAwMF0gQklPUy1lODIwOiBbbWVtIDB4MDAwMDAwMDAw MDA5ZmMwMC0weDAwMDAwMDAwMDAwOWZmZmZdIHJlc2VydmVkCj4gICA8Nj5bICAgIDAuMDAwMDAw XSBCSU9TLWU4MjA6IFttZW0gMHgwMDAwMDAwMDAwMGYwMDAwLTB4MDAwMDAwMDAwMDBmZmZmZl0g cmVzZXJ2ZWQKPiAgIDw2PlsgICAgMC4wMDAwMDBdIEJJT1MtZTgyMDogW21lbSAweDAwMDAwMDAw MDAxMDAwMDAtMHgwMDAwMDAwMDA3ZmRkZmZmXSB1c2FibGUKPiAgIDw2PlsgICAgMC4wMDAwMDBd IEJJT1MtZTgyMDogW21lbSAweDAwMDAwMDAwMDdmZGUwMDAtMHgwMDAwMDAwMDA3ZmZmZmZmXSBy ZXNlcnZlZAo+ICAgPDY+WyAgICAwLjAwMDAwMF0gQklPUy1lODIwOiBbbWVtIDB4MDAwMDAwMDBm ZWZmYzAwMC0weDAwMDAwMDAwZmVmZmZmZmZdIHJlc2VydmVkCj4gICA8Nj5bICAgIDAuMDAwMDAw XSBCSU9TLWU4MjA6IFttZW0gMHgwMDAwMDAwMGZmZmMwMDAwLTB4MDAwMDAwMDBmZmZmZmZmZl0g cmVzZXJ2ZWQKPiAgIDw2PlsgICAgMC4wMDAwMDBdIE5YIChFeGVjdXRlIERpc2FibGUpIHByb3Rl Y3Rpb246IGFjdGl2ZQo+ICAgPDY+WyAgICAwLjAwMDAwMF0gU01CSU9TIDIuOCBwcmVzZW50Lgo+ ICAgPDc+WyAgICAwLjAwMDAwMF0gRE1JOiBRRU1VIFN0YW5kYXJkIFBDIChpNDQwRlggKyBQSUlY LCAxOTk2KSwgQklPUyByZWwtMS45LjMtMC1nZTJmYzQxZS1wcmVidWlsdC5xZW11LXByb2plY3Qu b3JnIDA0LzAxLzIwMTQKPiAgIC4uLgo+IAo+IFRvIGVuYWJsZSBQU1RPUkVfVFlQRV9DT05TT0xF LCBhZGQgJ2NvbnNvbGU9dHJ1ZScgdG8gdmlydGlvLXBzdG9yZQo+IGRldmljZSBvcHRpb24uICBB bHNvICdidWZzaXplJyBvcHRpb24gY2FuIHNldCBkaWZmZXJlbnQgc2l6ZSBmb3IKPiBwc3RvcmUg YnVmZmVyIChkZWZhdWx0IGlzIDE2SykuICBNYXliZSB3ZSBjYW4gYWRkIGEgY29uZmlnIG9wdGlv biB0bwo+IGNvbnRyb2wgdGhlIGNvbXByZXNzaW9uIGxhdGVyLgo+IAo+IEN1cnJlbnRseSB0aGUg a3ZtdG9vbCBkb2Vzbid0IHN1cHBvcnQgYW55IG9wdGlvbnMgZXhjZXB0IHRoZSBkaXJlY3RvcnkK PiB0aGUgcHN0b3JlIHNhdmVzIHRoZSBsb2dzLgo+IAo+IAo+IE5hbWh5dW5nIEtpbSAoNyk6Cj4g ICBwc3RvcmU6IFNwbGl0IHBzdG9yZSBmcmFnaWxlIGZsYWdzCj4gICBwc3RvcmUvcmFtOiBTZXQg cHN0b3JlIGZsYWdzIGR5bmFtaWNhbGx5Cj4gICBwc3RvcmU6IE1hbmFnZSBidWZmZXIgcG9zaXRp b24gZm9yIGFzeW5jIHdyaXRlCj4gICB2aXJ0aW86IEJhc2ljIGltcGxlbWVudGF0aW9uIG9mIHZp cnRpbyBwc3RvcmUgZHJpdmVyCj4gICB2aXJ0aW8tcHN0b3JlOiBTdXBwb3J0IFBTVE9SRV9UWVBF X0NPTlNPTEUKPiAgIHFlbXU6IEltcGxlbWVudCB2aXJ0aW8tcHN0b3JlIGRldmljZQo+ICAga3Zt dG9vbDogSW1wbGVtZW50IHZpcnRpby1wc3RvcmUgZGV2aWNlCj4gCj4gIGRyaXZlcnMvYWNwaS9h cGVpL2Vyc3QuYyAgICAgICAgICAgICB8ICAgMiArLQo+ICBkcml2ZXJzL2Zpcm13YXJlL2VmaS9l ZmktcHN0b3JlLmMgICAgfCAgIDQgKy0KPiAgZHJpdmVycy92aXJ0aW8vS2NvbmZpZyAgICAgICAg ICAgICAgIHwgIDEwICsKPiAgZHJpdmVycy92aXJ0aW8vTWFrZWZpbGUgICAgICAgICAgICAgIHwg ICAxICsKPiAgZHJpdmVycy92aXJ0aW8vdmlydGlvX3BzdG9yZS5jICAgICAgIHwgNDIxICsrKysr KysrKysrKysrKysrKysrKwo+ICBmcy9wc3RvcmUvcGxhdGZvcm0uYyAgICAgICAgICAgICAgICAg fCAgNjUgKysrLQo+ICBmcy9wc3RvcmUvcmFtLmMgICAgICAgICAgICAgICAgICAgICAgfCAgIDgg Kwo+ICBpbmNsdWRlL2xpbnV4L3BzdG9yZS5oICAgICAgICAgICAgICAgfCAgIDkgKy0KPiAgaW5j bHVkZS91YXBpL2xpbnV4L0tidWlsZCAgICAgICAgICAgIHwgICAxICsKPiAgaW5jbHVkZS91YXBp L2xpbnV4L3ZpcnRpb19pZHMuaCAgICAgIHwgICAxICsKPiAgaW5jbHVkZS91YXBpL2xpbnV4L3Zp cnRpb19wc3RvcmUuaCAgIHwgIDc4ICsrKy0KPiAgMTEgZmlsZXMgY2hhbmdlZCwgNTgwIGluc2Vy dGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy92 aXJ0aW8vdmlydGlvX3BzdG9yZS5jCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL3VhcGkv bGludXgvdmlydGlvX3BzdG9yZS5oCj4gCj4gCj4gQ2M6IFBhb2xvIEJvbnppbmkgPHBib256aW5p QHJlZGhhdC5jb20+Cj4gQ2M6IFJhZGltIEtyxI1tw6HFmSA8cmtyY21hckByZWRoYXQuY29tPgo+ IENjOiAiTWljaGFlbCBTLiBUc2lya2luIiA8bXN0QHJlZGhhdC5jb20+Cj4gQ2M6IEFudGhvbnkg TGlndW9yaSA8YWxpZ3VvcmlAYW1hem9uLmNvbT4KPiBDYzogQW50b24gVm9yb250c292IDxhbnRv bkBlbm9tc2cub3JnPgo+IENjOiBDb2xpbiBDcm9zcyA8Y2Nyb3NzQGFuZHJvaWQuY29tPgo+IENj OiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4KPiBDYzogVG9ueSBMdWNrIDx0b255 Lmx1Y2tAaW50ZWwuY29tPgo+IENjOiBTdGV2ZW4gUm9zdGVkdCA8cm9zdGVkdEBnb29kbWlzLm9y Zz4KPiBDYzogSW5nbyBNb2xuYXIgPG1pbmdvQGtlcm5lbC5vcmc+Cj4gQ2M6IE1pbmNoYW4gS2lt IDxtaW5jaGFuQGtlcm5lbC5vcmc+Cj4gQ2M6IFdpbGwgRGVhY29uIDx3aWxsLmRlYWNvbkBhcm0u Y29tPgo+IENjOiBrdm1Admdlci5rZXJuZWwub3JnCj4gQ2M6IHFlbXUtZGV2ZWxAbm9uZ251Lm9y Zwo+IENjOiB2aXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwo+IAo+IFRo YW5rcywKPiBOYW1oeXVuZwo+IAo+IAo+IC0tIAo+IDIuOC4wCj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBWaXJ0dWFsaXphdGlvbiBtYWlsaW5n IGxpc3QKPiBWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwo+IGh0dHBz Oi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0 aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1 YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0 aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5m by92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163175AbcG0WTB (ORCPT ); Wed, 27 Jul 2016 18:19:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59256 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162535AbcG0WSu (ORCPT ); Wed, 27 Jul 2016 18:18:50 -0400 Date: Thu, 28 Jul 2016 01:18:42 +0300 From: "Michael S. Tsirkin" To: Namhyung Kim Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Tony Luck , Radim =?utf-8?B?S3LEjW3DocWZ?= , Kees Cook , Anton Vorontsov , Will Deacon , LKML , Steven Rostedt , Minchan Kim , Anthony Liguori , Colin Cross , Paolo Bonzini , Ingo Molnar Subject: Re: [RFC/PATCHSET 0/7] virtio: Implement virtio pstore device (v2) Message-ID: <20160728011602-mutt-send-email-mst@kernel.org> References: <1469632111-23260-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1469632111-23260-1-git-send-email-namhyung@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 27 Jul 2016 22:18:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2016 at 12:08:24AM +0900, Namhyung Kim wrote: > Hello, > > This is v2 of the virtio-pstore work. In this patchset I addressed > most of feedbacks from previous version. Limiting disk size is not > implemented yet. For some reason, only parts of the patchset were received. Pls post all patches to all lists. If you are changing the virtio interface with host, like a new device, they you must copy the virtio TC so make sure there are no objections from there. https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback > * changes in v2) > - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) > - make buffer size configurable (Cornelia) > - support PSTORE_TYPE_CONSOLE (Kees) > - use separate virtqueues for read and write > - support concurrent async write > - manage pstore (file) id in device side > - fix various mistakes in qemu device (Stefan) > > It started from the fact that dumping ftrace buffer at kernel > oops/panic takes too much time. Although there's a way to reduce the > size of the original data, sometimes I want to have the information as > many as possible. Maybe kexec/kdump can solve this problem but it > consumes some portion of guest memory so I'd like to avoid it. And I > know the qemu + crashtool can dump and analyze the whole guest memory > including the ftrace buffer without wasting guest memory, but it adds > one more layer and has some limitation as an out-of-tree tool like not > being in sync with the kernel changes. > > So I think it'd be great using the pstore interface to dump guest > kernel data on the host. One can read the data on the host directly > or on the guest (at the next boot) using pstore filesystem as usual. > While this patchset only implements dumping kernel log buffer, it can > be extended to have ftrace buffer and probably some more.. > > The patch 0001-0003 are preparation for pstore to support virtio > device which requires async write. The patch 0004 implements virtio > pstore driver. It has two virt queue for (sync) read and (async) > write, pstore buffer and io request and response structure. The > virtio_pstore_req struct is to give information about the current > pstore operation. The result will be written to the virtio_pstore_res > struct. For read operation it also uses virtio_pstore_fileinfo struct. > > The patch 0005 adds support for PSTORE_TYPE_CONSOLE which was > requested by Kees. The console data is appended to a single file for > now. > > The patch 0006 and 0007 implement virtio-pstore legacy PCI device on > qemu-kvm and kvmtool respectively. I referenced virtio-baloon and > virtio-rng implementations and I don't know whether kvmtool supports > modern virtio 1.0+ spec. Other transports might be supported later. > > For example, using virtio-pstore on qemu looks like below: > > $ qemu-system-x86_64 -enable-kvm -device virtio-pstore,directory=xxx > > When guest kernel gets panic the log messages will be saved under the > xxx directory. > > $ ls xxx > dmesg-1.enc.z dmesg-2.enc.z > > As you can see the pstore subsystem compresses the log data using zlib > (now supports lzo and lz4 too). The data can be extracted with the > following command: > > $ cat xxx/dmesg-1.enc.z | \ > > python -c 'import sys, zlib; print(zlib.decompress(sys.stdin.read()))' > Oops#1 Part1 > <5>[ 0.000000] Linux version 4.6.0kvm+ (namhyung@danjae) (gcc version 5.3.0 (GCC) ) #145 SMP Mon Jul 18 10:22:45 KST 2016 > <6>[ 0.000000] Command line: root=/dev/vda console=ttyS0 > <6>[ 0.000000] x86/fpu: Legacy x87 FPU detected. > <6>[ 0.000000] x86/fpu: Using 'eager' FPU context switches. > <6>[ 0.000000] e820: BIOS-provided physical RAM map: > <6>[ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable > <6>[ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x00000000000f0000-0x00000000000fffff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x0000000007fddfff] usable > <6>[ 0.000000] BIOS-e820: [mem 0x0000000007fde000-0x0000000007ffffff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x00000000feffc000-0x00000000feffffff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x00000000fffc0000-0x00000000ffffffff] reserved > <6>[ 0.000000] NX (Execute Disable) protection: active > <6>[ 0.000000] SMBIOS 2.8 present. > <7>[ 0.000000] DMI: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qemu-project.org 04/01/2014 > ... > > To enable PSTORE_TYPE_CONSOLE, add 'console=true' to virtio-pstore > device option. Also 'bufsize' option can set different size for > pstore buffer (default is 16K). Maybe we can add a config option to > control the compression later. > > Currently the kvmtool doesn't support any options except the directory > the pstore saves the logs. > > > Namhyung Kim (7): > pstore: Split pstore fragile flags > pstore/ram: Set pstore flags dynamically > pstore: Manage buffer position for async write > virtio: Basic implementation of virtio pstore driver > virtio-pstore: Support PSTORE_TYPE_CONSOLE > qemu: Implement virtio-pstore device > kvmtool: Implement virtio-pstore device > > drivers/acpi/apei/erst.c | 2 +- > drivers/firmware/efi/efi-pstore.c | 4 +- > drivers/virtio/Kconfig | 10 + > drivers/virtio/Makefile | 1 + > drivers/virtio/virtio_pstore.c | 421 +++++++++++++++++++++ > fs/pstore/platform.c | 65 +++- > fs/pstore/ram.c | 8 + > include/linux/pstore.h | 9 +- > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/virtio_ids.h | 1 + > include/uapi/linux/virtio_pstore.h | 78 +++- > 11 files changed, 580 insertions(+), 20 deletions(-) > create mode 100644 drivers/virtio/virtio_pstore.c > create mode 100644 include/uapi/linux/virtio_pstore.h > > > Cc: Paolo Bonzini > Cc: Radim Krčmář > Cc: "Michael S. Tsirkin" > Cc: Anthony Liguori > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Minchan Kim > Cc: Will Deacon > Cc: kvm@vger.kernel.org > Cc: qemu-devel@nongnu.org > Cc: virtualization@lists.linux-foundation.org > > Thanks, > Namhyung > > > -- > 2.8.0 > > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSXAE-0007CF-9i for qemu-devel@nongnu.org; Wed, 27 Jul 2016 18:18:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSXAA-0004DD-Pg for qemu-devel@nongnu.org; Wed, 27 Jul 2016 18:18:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSXAA-0004Cf-Hc for qemu-devel@nongnu.org; Wed, 27 Jul 2016 18:18:50 -0400 Date: Thu, 28 Jul 2016 01:18:42 +0300 From: "Michael S. Tsirkin" Message-ID: <20160728011602-mutt-send-email-mst@kernel.org> References: <1469632111-23260-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1469632111-23260-1-git-send-email-namhyung@kernel.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC/PATCHSET 0/7] virtio: Implement virtio pstore device (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Namhyung Kim Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Tony Luck , Radim =?utf-8?B?S3LEjW3DocWZ?= , Kees Cook , Anton Vorontsov , Will Deacon , LKML , Steven Rostedt , Minchan Kim , Anthony Liguori , Colin Cross , Paolo Bonzini , Ingo Molnar On Thu, Jul 28, 2016 at 12:08:24AM +0900, Namhyung Kim wrote: > Hello, >=20 > This is v2 of the virtio-pstore work. In this patchset I addressed > most of feedbacks from previous version. Limiting disk size is not > implemented yet. For some reason, only parts of the patchset were received. Pls post all patches to all lists. If you are changing the virtio interface with host, like a new device, they you must copy the virtio TC so make sure there are no objections from there. https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=3Dvirtio#feed= back > * changes in v2) > - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) > - make buffer size configurable (Cornelia) > - support PSTORE_TYPE_CONSOLE (Kees) > - use separate virtqueues for read and write > - support concurrent async write > - manage pstore (file) id in device side > - fix various mistakes in qemu device (Stefan) >=20 > It started from the fact that dumping ftrace buffer at kernel > oops/panic takes too much time. Although there's a way to reduce the > size of the original data, sometimes I want to have the information as > many as possible. Maybe kexec/kdump can solve this problem but it > consumes some portion of guest memory so I'd like to avoid it. And I > know the qemu + crashtool can dump and analyze the whole guest memory > including the ftrace buffer without wasting guest memory, but it adds > one more layer and has some limitation as an out-of-tree tool like not > being in sync with the kernel changes. >=20 > So I think it'd be great using the pstore interface to dump guest > kernel data on the host. One can read the data on the host directly > or on the guest (at the next boot) using pstore filesystem as usual. > While this patchset only implements dumping kernel log buffer, it can > be extended to have ftrace buffer and probably some more.. >=20 > The patch 0001-0003 are preparation for pstore to support virtio > device which requires async write. The patch 0004 implements virtio > pstore driver. It has two virt queue for (sync) read and (async) > write, pstore buffer and io request and response structure. The > virtio_pstore_req struct is to give information about the current > pstore operation. The result will be written to the virtio_pstore_res > struct. For read operation it also uses virtio_pstore_fileinfo struct. >=20 > The patch 0005 adds support for PSTORE_TYPE_CONSOLE which was > requested by Kees. The console data is appended to a single file for > now. >=20 > The patch 0006 and 0007 implement virtio-pstore legacy PCI device on > qemu-kvm and kvmtool respectively. I referenced virtio-baloon and > virtio-rng implementations and I don't know whether kvmtool supports > modern virtio 1.0+ spec. Other transports might be supported later. >=20 > For example, using virtio-pstore on qemu looks like below: >=20 > $ qemu-system-x86_64 -enable-kvm -device virtio-pstore,directory=3Dxx= x >=20 > When guest kernel gets panic the log messages will be saved under the > xxx directory. >=20 > $ ls xxx > dmesg-1.enc.z dmesg-2.enc.z >=20 > As you can see the pstore subsystem compresses the log data using zlib > (now supports lzo and lz4 too). The data can be extracted with the > following command: >=20 > $ cat xxx/dmesg-1.enc.z | \ > > python -c 'import sys, zlib; print(zlib.decompress(sys.stdin.read()= ))' > Oops#1 Part1 > <5>[ 0.000000] Linux version 4.6.0kvm+ (namhyung@danjae) (gcc vers= ion 5.3.0 (GCC) ) #145 SMP Mon Jul 18 10:22:45 KST 2016 > <6>[ 0.000000] Command line: root=3D/dev/vda console=3DttyS0 > <6>[ 0.000000] x86/fpu: Legacy x87 FPU detected. > <6>[ 0.000000] x86/fpu: Using 'eager' FPU context switches. > <6>[ 0.000000] e820: BIOS-provided physical RAM map: > <6>[ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fb= ff] usable > <6>[ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ff= ff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x00000000000f0000-0x00000000000fff= ff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x0000000007fddf= ff] usable > <6>[ 0.000000] BIOS-e820: [mem 0x0000000007fde000-0x0000000007ffff= ff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x00000000feffc000-0x00000000feffff= ff] reserved > <6>[ 0.000000] BIOS-e820: [mem 0x00000000fffc0000-0x00000000ffffff= ff] reserved > <6>[ 0.000000] NX (Execute Disable) protection: active > <6>[ 0.000000] SMBIOS 2.8 present. > <7>[ 0.000000] DMI: QEMU Standard PC (i440FX + PIIX, 1996), BIOS r= el-1.9.3-0-ge2fc41e-prebuilt.qemu-project.org 04/01/2014 > ... >=20 > To enable PSTORE_TYPE_CONSOLE, add 'console=3Dtrue' to virtio-pstore > device option. Also 'bufsize' option can set different size for > pstore buffer (default is 16K). Maybe we can add a config option to > control the compression later. >=20 > Currently the kvmtool doesn't support any options except the directory > the pstore saves the logs. >=20 >=20 > Namhyung Kim (7): > pstore: Split pstore fragile flags > pstore/ram: Set pstore flags dynamically > pstore: Manage buffer position for async write > virtio: Basic implementation of virtio pstore driver > virtio-pstore: Support PSTORE_TYPE_CONSOLE > qemu: Implement virtio-pstore device > kvmtool: Implement virtio-pstore device >=20 > drivers/acpi/apei/erst.c | 2 +- > drivers/firmware/efi/efi-pstore.c | 4 +- > drivers/virtio/Kconfig | 10 + > drivers/virtio/Makefile | 1 + > drivers/virtio/virtio_pstore.c | 421 +++++++++++++++++++++ > fs/pstore/platform.c | 65 +++- > fs/pstore/ram.c | 8 + > include/linux/pstore.h | 9 +- > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/virtio_ids.h | 1 + > include/uapi/linux/virtio_pstore.h | 78 +++- > 11 files changed, 580 insertions(+), 20 deletions(-) > create mode 100644 drivers/virtio/virtio_pstore.c > create mode 100644 include/uapi/linux/virtio_pstore.h >=20 >=20 > Cc: Paolo Bonzini > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 > Cc: "Michael S. Tsirkin" > Cc: Anthony Liguori > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: Steven Rostedt > Cc: Ingo Molnar > Cc: Minchan Kim > Cc: Will Deacon > Cc: kvm@vger.kernel.org > Cc: qemu-devel@nongnu.org > Cc: virtualization@lists.linux-foundation.org >=20 > Thanks, > Namhyung >=20 >=20 > --=20 > 2.8.0 >=20 > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization