From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSfyK-0001iE-Qy for qemu-devel@nongnu.org; Thu, 28 Jul 2016 03:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSfyG-0001Uw-J6 for qemu-devel@nongnu.org; Thu, 28 Jul 2016 03:43:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSfyG-0001Uh-Dy for qemu-devel@nongnu.org; Thu, 28 Jul 2016 03:43:08 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EEF93C04D2B0 for ; Thu, 28 Jul 2016 07:43:06 +0000 (UTC) Date: Thu, 28 Jul 2016 15:43:05 +0800 From: Fam Zheng Message-ID: <20160728074305.GA9625@ad.usersys.redhat.com> References: <1469600777-30413-1-git-send-email-famz@redhat.com> <1469600777-30413-4-git-send-email-famz@redhat.com> <4ca85cf1-602e-4c5c-54ac-773d97557229@redhat.com> <20160728051754.GA5510@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160728051754.GA5510@ad.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord Cc: Paolo Bonzini , qemu-devel@nongnu.org, Gerd Hoffmann On Thu, 07/28 13:17, Fam Zheng wrote: > > Maybe I'm doing something wrong, but when I apply this third patch > > (along with the first two) to master it doesn't seem to build when > > modules are enabled in the configuration: > > > > LINK x86_64-softmmu/qemu-system-x86_64 > > ../backends/baum.o: In function `chr_baum_init': > > /home/bos/clord/Documents/qemu/backends/baum.c:616: undefined reference > > to `SDL_GetWMInfo' > > collect2: error: ld returned 1 exit status > > Makefile:197: recipe for target 'qemu-system-x86_64' failed > > make[1]: *** [qemu-system-x86_64] Error 1 > > Makefile:204: recipe for target 'subdir-x86_64-softmmu' failed > > make: *** [subdir-x86_64-softmmu] Error 2 > > You are right, looks like audio and baum both want SDL library. I need to take > another look. We need to modularize backends/baum.c and add appropriate loading code somewhere (probably when it is specifically selected). In addition, audio/sdl.o should probably to be bundled together with ui/sdl.mo. I'll leave this series for now and you can pick up patch 1 into your series if it helps. Also feel free to pick up modularizing SDL and baum, if you want. Otherwise, I'll revisit these when your "load on demand" work settles down. Fam