All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: Some more feedback on Chapter 9
Date: Thu, 28 Jul 2016 10:40:57 -0700	[thread overview]
Message-ID: <20160728174057.GS3873@linux.vnet.ibm.com> (raw)
In-Reply-To: <a6181fde-e96e-294c-d0df-e996c27b401f@gmail.com>

On Thu, Jul 28, 2016 at 10:06:22PM +0900, Akira Yokosawa wrote:
> Hi Paul,
> 
> There are still several issues regarding Chapter 9 I want to feedback.
> I'm afraid most of them are beyond my ability to submit as patches.
> 
> * At the beginning of Section 9.5.2, there is a credit of the form
>   "Authors: ...".
>   But there is \OriginallyPublished{} command just above the credit.
>   I'm wondering if the credit in the text is necessary.
>   There is a similar credit at the beginning of Section 14.2, but there is
>   no \OriginallyPublished{} command there. This section seems to have been
>   written for perfbook. If this is the case, for a consistent look, it would
>   be better if the credit is moved to Appendix F.1.

Good point!  I am guessing that these predated \OriginallyPublished{}, and
that I didn't get around to fixing them properly.  I have now fixed them.

> * Position of Quick Quiz 9.44 looks a little premature. SRCU is  mentioned
>   just after the Quick Quiz.

Good catch, moved.

> * The 2nd sentence of Section 9.5.4.4 ends as "... in the companion article."
>   This seems like a vestige of its origin in LWN. Should be fixed to match
>   the context.

Now it is "Section~\ref{sec:defer:RCU Usage}", good eyes!

> * In the introduction of Section 9.5.5, understanding of the whole Chapter 9
>   is listed in the prerequisite for the "toy" implementation. I suppose
>   recursion is not intended here.

You know, that is strangely appropriate, now that you mention it!  ;-)

But how about the following?

	Nevertheless, you will need a thorough understanding of Chapters
	2, 3, 4, and 6, as well as the previous portions of Chapter 9 for
	even these toy RCU implementations to be easily understandable.

> * Also in the introduction of Section 9.5.5, Section 9.5.5.2 is not mentioned.

Fixed!  Now "Section 9.5.5.2 through 9.5.5.9".

> * (Typo) In the 2nd paragraph of Section 9.7, there is a redundant "can" in
>   "... so that updates can can operate locally, ...".
>   (Yes, I can submit the fix of this one as a patch. If you want me to do so,
>   please let me know.)

I fixed it with your Reported-by.

And here is the Youtube video corresponding to that particular typo:

	https://www.youtube.com/watch?v=4Diu2N8TGKA

> * (Apart from Chapter 9) In Section 14.2.10.1, there are four instances of
>   $\dagger$ for introducing notes. I'm wondering if they can be converted
>   to footnotes. I'm not sure where they should be placed in the text, though.

Odd.  Those were there in the initial git commit.

I am removing the $\dagger$ commands and thus letting them be normal
paragraphs.

> I said earlier there were a few issues, but in the end there are a quite a few.
> 
> I don't mind if some (or all) of them be taken care of later after the upcoming
> release.

They were all reasonably easy, so might as well do them now.  Famous
last words.  ;-)

I commited and pushed them all.

							Thanx, Paul


  reply	other threads:[~2016-07-28 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 13:06 Some more feedback on Chapter 9 Akira Yokosawa
2016-07-28 17:40 ` Paul E. McKenney [this message]
2016-07-28 21:41   ` Akira Yokosawa
2016-07-28 22:19     ` Paul E. McKenney
2016-07-28 21:59   ` Akira Yokosawa
2016-07-28 22:21     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728174057.GS3873@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.