From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Daniel Wagner <wagi@monom.org>,
Bastien Nocera <hadess@hadess.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johannes Berg <johannes.berg@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion
Date: Thu, 28 Jul 2016 12:01:51 -0700 [thread overview]
Message-ID: <20160728190151.GV13516@tuxbot> (raw)
In-Reply-To: <20160728183343.GD16852@dtor-ws>
On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote:
> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote:
> > From: Daniel Wagner <daniel.wagner@bmw-carit.de>
> >
[..]
>
> Do not quite like it... I'd rather asynchronous request give out a
> firmware status pointer that could be used later on.
>
> pcu->fw_st = request_firmware_async(IMS_PCU_FIRMWARE_NAME,
> pcu,
> ims_pcu_process_async_firmware);
> if (IS_ERR(pcu->fw_st))
> return PTR_ERR(pcu->fw_st);
>
> ....
>
> fw_loading_wait(pcu->fw_st);
>
In the remoteproc case (patch 6) this would clean up the code, rather
than replacing the completion API 1 to 1. I like it!
Regards,
Bjorn
next prev parent reply other threads:[~2016-07-28 19:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 7:55 [RFC v0 0/8] Reuse firmware loader helpers Daniel Wagner
2016-07-28 7:55 ` [RFC v0 1/8] selftests: firmware: do not abort test too early Daniel Wagner
2016-07-28 7:55 ` [RFC v0 2/8] selftests: firmware: do not clutter output Daniel Wagner
2016-07-28 7:55 ` [RFC v0 3/8] firmware: Factor out firmware load helpers Daniel Wagner
2016-07-28 15:01 ` Dan Williams
2016-07-28 15:01 ` Dan Williams
2016-07-29 6:07 ` Daniel Wagner
2016-07-29 6:07 ` Daniel Wagner
2016-07-28 17:57 ` Dmitry Torokhov
2016-07-29 6:08 ` Daniel Wagner
2016-07-29 6:08 ` Daniel Wagner
2016-07-28 7:55 ` [RFC v0 4/8] Input: goodix: use firmware_stat instead of completion Daniel Wagner
2016-07-28 11:22 ` Bastien Nocera
2016-07-28 11:59 ` Daniel Wagner
2016-07-28 11:59 ` Daniel Wagner
2016-07-28 12:20 ` Bastien Nocera
2016-07-28 13:10 ` Daniel Wagner
2016-07-28 13:10 ` Daniel Wagner
2016-07-28 7:55 ` [RFC v0 5/8] ath9k_htc: " Daniel Wagner
2016-07-28 7:55 ` [RFC v0 6/8] remoteproc: " Daniel Wagner
2016-07-28 7:55 ` [RFC v0 7/8] Input: ims-pcu: " Daniel Wagner
2016-07-28 18:33 ` Dmitry Torokhov
2016-07-28 19:01 ` Bjorn Andersson [this message]
2016-07-29 6:13 ` Daniel Wagner
2016-07-29 6:13 ` Daniel Wagner
2016-07-30 12:42 ` Arend van Spriel
2016-07-30 16:58 ` Luis R. Rodriguez
2016-07-31 7:23 ` Dmitry Torokhov
[not found] ` <C528E404-0CA5-46B4-B551-B1D4B58BC053-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-01 12:26 ` Daniel Wagner
2016-08-01 12:26 ` Daniel Wagner
[not found] ` <37a3cd66-262e-ffbe-ea7a-a6d5b1ca1c8b-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2016-08-01 19:44 ` Luis R. Rodriguez
2016-08-01 19:44 ` Luis R. Rodriguez
2016-08-02 5:49 ` Daniel Wagner
2016-08-02 5:49 ` Daniel Wagner
2016-08-02 6:34 ` Luis R. Rodriguez
[not found] ` <20160802063419.GG3296-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2016-08-02 6:53 ` Daniel Wagner
2016-08-02 6:53 ` Daniel Wagner
[not found] ` <2713d779-ef55-793d-f37e-d1414bb1bfc2-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2016-08-02 7:41 ` Luis R. Rodriguez
2016-08-02 7:41 ` Luis R. Rodriguez
2016-08-03 6:57 ` Daniel Wagner
2016-08-03 6:57 ` Daniel Wagner
[not found] ` <ef14dc68-d2f8-0934-7be5-dfb3a4771f27-98C5kh4wR6ohFhg+JK9F0w@public.gmane.org>
2016-08-03 15:55 ` Luis R. Rodriguez
2016-08-03 15:55 ` Luis R. Rodriguez
2016-08-03 16:18 ` Dmitry Torokhov
2016-08-03 17:37 ` Luis R. Rodriguez
[not found] ` <20160803155540.GL3296-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2016-08-03 18:40 ` Luis R. Rodriguez
2016-08-03 18:40 ` Luis R. Rodriguez
2016-08-03 22:26 ` Bjorn Andersson
2016-08-03 7:42 ` Dmitry Torokhov
2016-08-03 11:43 ` Arend van Spriel
2016-08-03 15:18 ` Luis R. Rodriguez
2016-08-03 15:35 ` Dmitry Torokhov
2016-08-03 20:42 ` Arend van Spriel
2016-08-03 20:42 ` Arend van Spriel
2016-08-03 16:03 ` Luis R. Rodriguez
[not found] ` <20160802074106.GI3296-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2016-08-03 17:39 ` Bjorn Andersson
2016-08-03 17:39 ` Bjorn Andersson
2016-08-03 18:08 ` Luis R. Rodriguez
2016-08-01 19:36 ` Luis R. Rodriguez
2016-08-01 17:19 ` Bjorn Andersson
2016-08-01 19:56 ` Luis R. Rodriguez
2016-08-01 21:34 ` Dmitry Torokhov
2016-07-31 7:17 ` Dmitry Torokhov
2016-07-28 7:55 ` [RFC v0 8/8] iwl4965: " Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728190151.GV13516@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.